From: Laszlo Ersek <lersek@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>, qemu-devel@nongnu.org
Cc: imammedo@redhat.com, anderson@redhat.com, berrange@redhat.com,
ehabkost@redhat.com
Subject: Re: [Qemu-devel] [PATCH v3 0/7] KASLR kernel dump support
Date: Tue, 11 Jul 2017 22:26:03 +0200 [thread overview]
Message-ID: <f668daab-6e6a-9ea0-b2ee-e4c36388f185@redhat.com> (raw)
In-Reply-To: <20170711103011.32631-1-marcandre.lureau@redhat.com>
On 07/11/17 12:30, Marc-André Lureau wrote:
> v3: from Laszlo review
> - change vmcoreinfo offset to 36
> - reset err to null after report
> - use PRIu32
> - change name_size and desc_size against MAX_VMCOREINFO_SIZE
> - python code simplification
> - check boundaries of blocks in phys_memory_read()
> - fix some vmgi vs vmci names
> - add more comments in code
> - fix comment indentation
> - add r-b tags
I compared patches #1, #2, #5, #7 too, against v2 -- there have been
some justified changes (wherever appropriate); my earlier R-b / A-b tags
stand.
Thanks
Laszlo
prev parent reply other threads:[~2017-07-11 20:26 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-11 10:30 [Qemu-devel] [PATCH v3 0/7] KASLR kernel dump support Marc-André Lureau
2017-07-11 10:30 ` [Qemu-devel] [PATCH v3 1/7] vmgenid: replace x-write-pointer-available hack Marc-André Lureau
2017-07-11 10:30 ` [Qemu-devel] [PATCH v3 2/7] acpi: add vmcoreinfo device Marc-André Lureau
2017-07-11 10:30 ` [Qemu-devel] [PATCH v3 3/7] tests: add simple vmcoreinfo test Marc-André Lureau
2017-07-11 19:49 ` Laszlo Ersek
2017-07-11 10:30 ` [Qemu-devel] [PATCH v3 4/7] dump: add vmcoreinfo ELF note Marc-André Lureau
2017-07-11 20:04 ` Laszlo Ersek
2017-07-11 20:14 ` Eduardo Habkost
2017-07-11 10:30 ` [Qemu-devel] [PATCH v3 5/7] kdump: " Marc-André Lureau
2017-07-11 10:30 ` [Qemu-devel] [PATCH v3 6/7] scripts/dump-guest-memory.py: add vmcoreinfo Marc-André Lureau
2017-07-11 20:22 ` Laszlo Ersek
2017-07-12 0:08 ` Marc-André Lureau
2017-07-13 15:36 ` Marc-André Lureau
2017-07-13 19:26 ` Laszlo Ersek
2017-07-11 10:30 ` [Qemu-devel] [PATCH v3 7/7] MAINTAINERS: add Dump maintainers Marc-André Lureau
2017-07-11 12:45 ` [Qemu-devel] [PATCH v3 0/7] KASLR kernel dump support no-reply
2017-07-11 13:23 ` Marc-André Lureau
2017-07-11 20:26 ` Laszlo Ersek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f668daab-6e6a-9ea0-b2ee-e4c36388f185@redhat.com \
--to=lersek@redhat.com \
--cc=anderson@redhat.com \
--cc=berrange@redhat.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).