From: Laurent Vivier <lvivier@redhat.com>
To: Thomas Huth <thuth@redhat.com>, qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"David Gibson" <david@gibson.dropbear.id.au>,
qemu-ppc@nongnu.org, "Greg Kurz" <groug@kaod.org>,
"Cédric Le Goater" <clg@kaod.org>
Subject: Re: [PATCH 1/2] qtest: Fix rtas dependencies
Date: Wed, 5 Feb 2020 21:49:04 +0100 [thread overview]
Message-ID: <f69cefe7-01ec-43f8-60b7-d001b47bd559@redhat.com> (raw)
In-Reply-To: <2745c304-0918-e51a-7988-c039522b3e14@redhat.com>
On 05/02/2020 21:46, Thomas Huth wrote:
> On 05/02/2020 21.41, Laurent Vivier wrote:
>> qtest "rtas" command is only available with pseries not all ppc64 targets,
>> so if I try to compile only powernv machine, the build fails with:
>>
>> /usr/bin/ld: qtest.o: in function `qtest_process_command':
>> .../qtest.c:645: undefined reference to `qtest_rtas_call'
>>
>> We fix this by enabling rtas command only with pseries machine.
>>
>> Fixes: eeddd59f5962 ("tests: add RTAS command in the protocol")
>
> Well, at that point in time CONFIG_PSERIES was not available yet ... so
> not sure if the "Fixes:" really makes sense here...
You are right, but I think it's interesting to show the dependency we
have between patches.
> But apart from that:
> Reviewed-by: Thomas Huth <thuth@redhat.com>
>
Thank you!
Laurent
next prev parent reply other threads:[~2020-02-05 20:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-05 20:41 [PATCH 0/2] ppc/pnv: fix build dependencies Laurent Vivier
2020-02-05 20:41 ` [PATCH 1/2] qtest: Fix rtas dependencies Laurent Vivier
2020-02-05 20:46 ` Thomas Huth
2020-02-05 20:49 ` Laurent Vivier [this message]
2020-02-05 20:41 ` [PATCH 2/2] ppc/pnv: Fix PCI_EXPRESS dependency Laurent Vivier
2020-02-05 21:20 ` Greg Kurz
2020-02-05 23:17 ` Laurent Vivier
2020-02-06 6:31 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f69cefe7-01ec-43f8-60b7-d001b47bd559@redhat.com \
--to=lvivier@redhat.com \
--cc=clg@kaod.org \
--cc=david@gibson.dropbear.id.au \
--cc=groug@kaod.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).