* [RFC PATCH] Makefile: trigger re-configure on updated pythondeps
@ 2024-07-31 14:02 Alex Bennée
2024-07-31 22:13 ` Richard Henderson
2024-08-01 5:19 ` Philippe Mathieu-Daudé
0 siblings, 2 replies; 3+ messages in thread
From: Alex Bennée @ 2024-07-31 14:02 UTC (permalink / raw)
To: qemu-devel; +Cc: Alex Bennée, Paolo Bonzini, Thomas Huth
If we add additional deps for meson we need to ensure we trigger a
reconfigure to make sure everything is set up.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index 02a257584b..0281a883a1 100644
--- a/Makefile
+++ b/Makefile
@@ -78,7 +78,7 @@ x := $(shell rm -rf meson-private meson-info meson-logs)
endif
# 1. ensure config-host.mak is up-to-date
-config-host.mak: $(SRC_PATH)/configure $(SRC_PATH)/scripts/meson-buildoptions.sh $(SRC_PATH)/VERSION
+config-host.mak: $(SRC_PATH)/configure $(SRC_PATH)/scripts/meson-buildoptions.sh $(SRC_PATH)/pythondeps.toml $(SRC_PATH)/VERSION
@echo config-host.mak is out-of-date, running configure
@if test -f meson-private/coredata.dat; then \
./config.status --skip-meson; \
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [RFC PATCH] Makefile: trigger re-configure on updated pythondeps
2024-07-31 14:02 [RFC PATCH] Makefile: trigger re-configure on updated pythondeps Alex Bennée
@ 2024-07-31 22:13 ` Richard Henderson
2024-08-01 5:19 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Richard Henderson @ 2024-07-31 22:13 UTC (permalink / raw)
To: Alex Bennée, qemu-devel; +Cc: Paolo Bonzini, Thomas Huth
On 8/1/24 00:02, Alex Bennée wrote:
> If we add additional deps for meson we need to ensure we trigger a
> reconfigure to make sure everything is set up.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 02a257584b..0281a883a1 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -78,7 +78,7 @@ x := $(shell rm -rf meson-private meson-info meson-logs)
> endif
>
> # 1. ensure config-host.mak is up-to-date
> -config-host.mak: $(SRC_PATH)/configure $(SRC_PATH)/scripts/meson-buildoptions.sh $(SRC_PATH)/VERSION
> +config-host.mak: $(SRC_PATH)/configure $(SRC_PATH)/scripts/meson-buildoptions.sh $(SRC_PATH)/pythondeps.toml $(SRC_PATH)/VERSION
> @echo config-host.mak is out-of-date, running configure
> @if test -f meson-private/coredata.dat; then \
> ./config.status --skip-meson; \
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFC PATCH] Makefile: trigger re-configure on updated pythondeps
2024-07-31 14:02 [RFC PATCH] Makefile: trigger re-configure on updated pythondeps Alex Bennée
2024-07-31 22:13 ` Richard Henderson
@ 2024-08-01 5:19 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2024-08-01 5:19 UTC (permalink / raw)
To: Alex Bennée, qemu-devel; +Cc: Paolo Bonzini, Thomas Huth
On 31/7/24 16:02, Alex Bennée wrote:
> If we add additional deps for meson we need to ensure we trigger a
> reconfigure to make sure everything is set up.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 02a257584b..0281a883a1 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -78,7 +78,7 @@ x := $(shell rm -rf meson-private meson-info meson-logs)
> endif
>
> # 1. ensure config-host.mak is up-to-date
> -config-host.mak: $(SRC_PATH)/configure $(SRC_PATH)/scripts/meson-buildoptions.sh $(SRC_PATH)/VERSION
> +config-host.mak: $(SRC_PATH)/configure $(SRC_PATH)/scripts/meson-buildoptions.sh $(SRC_PATH)/pythondeps.toml $(SRC_PATH)/VERSION
This long line could be split with \, otherwise:
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> @echo config-host.mak is out-of-date, running configure
> @if test -f meson-private/coredata.dat; then \
> ./config.status --skip-meson; \
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-08-01 5:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-31 14:02 [RFC PATCH] Makefile: trigger re-configure on updated pythondeps Alex Bennée
2024-07-31 22:13 ` Richard Henderson
2024-08-01 5:19 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).