From: Paolo Bonzini <pbonzini@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: Eric Farman <farman@linux.ibm.com>,
Peter Maydell <peter.maydell@linaro.org>,
Halil Pasic <pasic@linux.ibm.com>,
Richard Henderson <richard.henderson@linaro.org>,
David Hildenbrand <david@redhat.com>,
qemu-s390x@nongnu.org, Ilya Leoshkevich <iii@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
Thomas Huth <thuth@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [PATCH v2 0/2] target/s390x: Fix tracing header path in TCG mem_helper.c
Date: Tue, 18 Jun 2024 17:11:35 +0200 [thread overview]
Message-ID: <f6acedfe-b117-4bf7-a89a-45ad1a12c52a@redhat.com> (raw)
In-Reply-To: <20240613104415.9643-1-philmd@linaro.org>
On 6/13/24 12:44, Philippe Mathieu-Daudé wrote:
> In order to keep trace event headers local to their
> directory, introduce s390_skeys_get/s390_skeys_set
> helpers, fixing:
>
> In file included from ../../target/s390x/tcg/mem_helper.c:33:
> ../../target/s390x/tcg/trace.h:1:10: fatal error: 'trace/trace-target_s390x_tcg.h' file not found
> #include "trace/trace-target_s390x_tcg.h"
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 1 error generated.
> ninja: build stopped: subcommand failed.
>
> Philippe Mathieu-Daudé (2):
> hw/s390x: Introduce s390_skeys_get|set() helpers
> target/s390x: Use s390_skeys_get|set() helper
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
> include/hw/s390x/storage-keys.h | 10 ++++++++++
> hw/s390x/s390-skeys.c | 27 +++++++++++++++++++++++++++
> target/s390x/mmu_helper.c | 11 ++---------
> target/s390x/tcg/mem_helper.c | 16 ++++------------
> hw/s390x/trace-events | 4 ++++
> target/s390x/trace-events | 4 ----
> 6 files changed, 47 insertions(+), 25 deletions(-)
>
next prev parent reply other threads:[~2024-06-18 15:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-13 10:44 [PATCH v2 0/2] target/s390x: Fix tracing header path in TCG mem_helper.c Philippe Mathieu-Daudé
2024-06-13 10:44 ` [PATCH v2 1/2] hw/s390x: Introduce s390_skeys_get|set() helpers Philippe Mathieu-Daudé
2024-06-13 10:44 ` [PATCH v2 2/2] target/s390x: Use s390_skeys_get|set() helper Philippe Mathieu-Daudé
2024-06-18 10:39 ` [PATCH v2 0/2] target/s390x: Fix tracing header path in TCG mem_helper.c Philippe Mathieu-Daudé
2024-06-18 13:04 ` Thomas Huth
2024-06-18 15:11 ` Paolo Bonzini [this message]
2024-06-18 15:58 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6acedfe-b117-4bf7-a89a-45ad1a12c52a@redhat.com \
--to=pbonzini@redhat.com \
--cc=borntraeger@linux.ibm.com \
--cc=david@redhat.com \
--cc=farman@linux.ibm.com \
--cc=iii@linux.ibm.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=pasic@linux.ibm.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).