From: Richard Henderson <richard.henderson@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [RFC PATCH] configure: remove all dependencies on a (re)configure
Date: Fri, 10 Jul 2020 12:19:27 -0700 [thread overview]
Message-ID: <f6b6f12d-4917-7256-0583-63f77951bb4f@linaro.org> (raw)
In-Reply-To: <20200708175335.31292-1-alex.bennee@linaro.org>
On 7/8/20 10:53 AM, Alex Bennée wrote:
> The previous code was brittle and missed cases such as the mipn32
> variants which for some reason has the 64 bit syscalls. This leads to
> a number of binary targets having deps lines like:
>
> all.clang-sanitizer/mipsn32el-linux-user/linux-user/signal.d
> 140: /home/alex/lsrc/qemu.git/linux-user/mips64/syscall_nr.h \
> 455:/home/alex/lsrc/qemu.git/linux-user/mips64/syscall_nr.h:
>
> all.clang-sanitizer/mipsn32el-linux-user/linux-user/syscall.d
> 146: /home/alex/lsrc/qemu.git/linux-user/mips64/syscall_nr.h \
> 485:/home/alex/lsrc/qemu.git/linux-user/mips64/syscall_nr.h:
>
> which in turn would trigger the re-generation of syscall_nr.h in the
> source tree (thanks to generic %/syscall_nr.h rules). The previous
> code attempts to clean it out but misses edge cases but fails.
>
> After spending a day trying to understand how this was happening I'm
> unconvinced that there are not other such breakages possible with this
> "caching". As we add more auto-generated code to the build it is likely
> to trip up again. Apply a hammer to the problem.
>
> Fixes: 91e5998f18 (which fixes 5f29856b852d and 4d6a835dea47)
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> configure | 15 ++++++---------
> 1 file changed, 6 insertions(+), 9 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
prev parent reply other threads:[~2020-07-10 19:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-08 17:53 [RFC PATCH] configure: remove all dependencies on a (re)configure Alex Bennée
2020-07-10 19:19 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6b6f12d-4917-7256-0583-63f77951bb4f@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).