From: Paolo Bonzini <pbonzini@redhat.com>
To: "Daniel P. Berrange" <berrange@redhat.com>,
linzhecheng <linzhecheng@huawei.com>
Cc: qemu-devel@nongnu.org, arei.gonglei@huawei.com
Subject: Re: [Qemu-devel] [PATCH] thread: move detach_thread from creating thread to created thread
Date: Mon, 27 Nov 2017 16:18:21 +0100 [thread overview]
Message-ID: <f6b7370a-c4b9-2289-42b3-41bceefad634@redhat.com> (raw)
In-Reply-To: <20171127150852.GO32413@redhat.com>
On 27/11/2017 16:08, Daniel P. Berrange wrote:
> We should just do
>
> if (mode == QEMU_THREAD_DETACHED) {
> pthread_attr_setdetachstate(&attr, PTHREAD_CREATE_DETACHED);
> }
>
This is true, but Zhecheng's patch (when fixed---see patchew's report)
would also fix a similar race on pthread_setname_np, so I think it's
fine to introduce qemu_thread_start.
Thanks,
Paolo
next prev parent reply other threads:[~2017-11-27 15:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-27 14:59 [Qemu-devel] [PATCH] thread: move detach_thread from creating thread to created thread linzhecheng
2017-11-27 15:04 ` no-reply
2017-11-27 15:08 ` Daniel P. Berrange
2017-11-27 15:18 ` Paolo Bonzini [this message]
2017-11-27 15:09 ` no-reply
2017-11-27 15:18 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6b7370a-c4b9-2289-42b3-41bceefad634@redhat.com \
--to=pbonzini@redhat.com \
--cc=arei.gonglei@huawei.com \
--cc=berrange@redhat.com \
--cc=linzhecheng@huawei.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).