From: Richard Henderson <richard.henderson@linaro.org>
To: Laurent Vivier <laurent@vivier.eu>, qemu-devel@nongnu.org
Cc: "YunQiang Su" <syq@debian.org>,
"Riku Voipio" <riku.voipio@iki.fi>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Aaron Sierra" <asierra@xes-inc.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: Re: [Qemu-devel] [PATCH 1/3] linux-user: introduce functions to detect CPU type
Date: Tue, 16 Jan 2018 07:54:31 -0800 [thread overview]
Message-ID: <f6ba6a57-43fe-f4ee-4dac-0e5e7a3b49fd@linaro.org> (raw)
In-Reply-To: <addf3223-da94-6573-5e87-408ec8367d4a@vivier.eu>
On 01/16/2018 06:13 AM, Laurent Vivier wrote:
>> There is no reason to read the elf header twice -- e_flags has already been
>> stored in the struct image_info.
>
> When we set cpu_model, image_info is not initialized.
> Do you propose to move cpu_init() after loader_exec()?
Sure.
r~
next prev parent reply other threads:[~2018-01-16 15:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-13 14:48 [Qemu-devel] [PATCH 0/3] linux-user: select CPU type according ELF header values Laurent Vivier
2018-01-13 14:48 ` [Qemu-devel] [PATCH 1/3] linux-user: introduce functions to detect CPU type Laurent Vivier
2018-01-15 22:04 ` Richard Henderson
2018-01-16 14:13 ` Laurent Vivier
2018-01-16 15:54 ` Richard Henderson [this message]
2018-01-16 16:56 ` Laurent Vivier
2018-01-13 14:48 ` [Qemu-devel] [PATCH 2/3] linux-user, m68k: select CPU according to ELF header values Laurent Vivier
2018-01-13 14:48 ` [Qemu-devel] [PATCH 3/3] linux-user: MIPS set cpu to r6 CPU if binary is R6 Laurent Vivier
2018-01-17 2:26 ` YunQiang Su
2018-01-17 7:44 ` Laurent Vivier
2018-01-24 8:24 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6ba6a57-43fe-f4ee-4dac-0e5e7a3b49fd@linaro.org \
--to=richard.henderson@linaro.org \
--cc=asierra@xes-inc.com \
--cc=f4bug@amsat.org \
--cc=laurent@vivier.eu \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
--cc=syq@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).