From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54573) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ebTZP-00052Q-IX for qemu-devel@nongnu.org; Tue, 16 Jan 2018 10:54:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ebTZL-0005qA-P0 for qemu-devel@nongnu.org; Tue, 16 Jan 2018 10:54:39 -0500 Received: from mail-pg0-x243.google.com ([2607:f8b0:400e:c05::243]:40180) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ebTZL-0005pb-J2 for qemu-devel@nongnu.org; Tue, 16 Jan 2018 10:54:35 -0500 Received: by mail-pg0-x243.google.com with SMTP id g16so3083702pgn.7 for ; Tue, 16 Jan 2018 07:54:35 -0800 (PST) References: <20180113144847.8403-1-laurent@vivier.eu> <20180113144847.8403-2-laurent@vivier.eu> <8106f80a-6bd2-8ba6-125a-6d5e58fcb035@linaro.org> From: Richard Henderson Message-ID: Date: Tue, 16 Jan 2018 07:54:31 -0800 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/3] linux-user: introduce functions to detect CPU type List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laurent Vivier , qemu-devel@nongnu.org Cc: YunQiang Su , Riku Voipio , Peter Maydell , Aaron Sierra , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= On 01/16/2018 06:13 AM, Laurent Vivier wrote: >> There is no reason to read the elf header twice -- e_flags has already been >> stored in the struct image_info. > > When we set cpu_model, image_info is not initialized. > Do you propose to move cpu_init() after loader_exec()? Sure. r~