qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Cédric Le Goater" <clg@redhat.com>
To: Kunkun Jiang <jiangkunkun@huawei.com>,
	Alex Williamson <alex.williamson@redhat.com>,
	Yishai Hadas <yishaih@nvidia.com>
Cc: "open list:All patches CC here" <qemu-devel@nongnu.org>,
	wanghaibin.wang@huawei.com, Zenghui Yu <yuzenghui@huawei.com>,
	'Avihai Horon' <avihaih@nvidia.com>
Subject: Re: [Question] VFIO migration will not be aborted in a corner scenario
Date: Mon, 11 Aug 2025 18:34:57 +0200	[thread overview]
Message-ID: <f6c1cff4-a0ca-436a-b8d7-3d19ce49e848@redhat.com> (raw)
In-Reply-To: <6f64724d-7869-1283-bb75-193c7fba5576@huawei.com>

Hello,

+ Avihai

On 8/11/25 18:02, Kunkun Jiang wrote:
> Hi all,
> 
> While testing VFIO migration, I encountered an corner scenario case:
> VFIO migration will not be aborted when the vfio device of dst-vm fails to transition from RESUMING to RUNNING state in vfio_vmstate_change.
> 
> I saw the comments in the vfio_vmstate_change but I don't understand why no action is taken for this situation. 

There is error handling in vfio_vmstate_change() :

         /*
          * Migration should be aborted in this case, but vm_state_notify()
          * currently does not support reporting failures.
          */
         migration_file_set_error(ret, local_err);

> Allowing the live migration process to continue could cause unrecoverable damage to the VM. In this case, can we directly exit the dst-vm? Through the return-path mechanism, the src-vm can continue to run.
> 
> Looking forward to your reply.

I suggest you open an issue on :

   https://gitlab.com/qemu-project/qemu/-/issues/

with a detailed description of your environment :
   
   Host HW, Host OS, QEMU version, QEMU command line, Guest OS, etc.

A template is provided when a new issue is created.


Thanks,

C.
  




  reply	other threads:[~2025-08-11 16:36 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-11 16:02 [Question] VFIO migration will not be aborted in a corner scenario Kunkun Jiang via
2025-08-11 16:34 ` Cédric Le Goater [this message]
2025-08-12 14:08   ` Avihai Horon
2025-08-12 14:34     ` Cédric Le Goater
2025-08-12 14:58       ` Peter Xu
2025-08-18  6:10         ` Avihai Horon
2025-08-12 14:56     ` Cédric Le Goater
2025-08-13 12:18       ` Kunkun Jiang via
2025-08-18  6:13       ` Avihai Horon
2025-08-13 12:18     ` Kunkun Jiang via
2025-08-18  6:44       ` Avihai Horon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f6c1cff4-a0ca-436a-b8d7-3d19ce49e848@redhat.com \
    --to=clg@redhat.com \
    --cc=alex.williamson@redhat.com \
    --cc=avihaih@nvidia.com \
    --cc=jiangkunkun@huawei.com \
    --cc=qemu-devel@nongnu.org \
    --cc=wanghaibin.wang@huawei.com \
    --cc=yishaih@nvidia.com \
    --cc=yuzenghui@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).