From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 112F0C4332F for ; Wed, 4 Jan 2023 12:27:51 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pD2rl-0007IQ-C7; Wed, 04 Jan 2023 07:27:33 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pD2rk-0007I3-7s for qemu-devel@nongnu.org; Wed, 04 Jan 2023 07:27:32 -0500 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pD2ri-0002sn-6v for qemu-devel@nongnu.org; Wed, 04 Jan 2023 07:27:31 -0500 Received: by mail-wm1-x32d.google.com with SMTP id fm16-20020a05600c0c1000b003d96fb976efso24076143wmb.3 for ; Wed, 04 Jan 2023 04:27:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=hLzdyhgVTM88j5OJjrDPGLWa67LwfAhsawd7HzxbNvk=; b=TOysUlZy+FrrQfNAnCAh7AVgK4nyg9mgvTtBWgEk4eOiho7e04HUNQnQCjcQjDZA5h 2VxIfpx3/4xC7GCWhkooBsS4ITWNIgMCystJjrs6rn+jLixca+Yj/k53G2esFutmMzI1 wwn9BigwJnruIElNH07oZHu3VLjvrSKa1sIiz8C3h9+nGg4C6ycXwuKaWtoDDiYxgo32 XU0sKqN+vPIIeGXtQUihJIvj7oIZYa3L3oTF6/ubcSI5M/vi8h+XTVsYJHyhee7QYiSn S4SEWoSFAkVi2Od+5S1utw1GmxOJK/jDv7//ZKUnC7uUOnE2hUtyj7UBa6XoSMh9L/nx EAcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hLzdyhgVTM88j5OJjrDPGLWa67LwfAhsawd7HzxbNvk=; b=sPLqewMNDR1GOXt5zyrf3+JeMPhQ38ltyxU0QtM3VzIHpldHEBKkBvBgSbSyEJikXF XIsMddr4Nrf2orOi6Khe7gYY0PBV51PKYTHrLCpdzsjy4NjprP+BYsDfDmlp5TfXLVQv ePa4DvpPHhaJNAkDEIbDeNrZ5Bv637LL/BV7zdV4bzhGUUAWzonzTPiTmLA06p8MRU2H /Vpq7wmI/MbQ8c3UvEhqkqDQzjnfN3XXKP3I0uvykYXJp7TtKSrAuD1B/75G6eCTLHdL mWNyhQviJzN41qyWEqPdvKZUgY2ffCN8TAzKDJEr/TeK3YG/BGVYg5hFQsFpcY1nurYb vG8A== X-Gm-Message-State: AFqh2krK1ZT2s2DKqZqrSnkG4tMlWLC0zAyMnv+iSw3Ejz8qDxWfxQh3 5KUfEs1UxHt0icY1+9P778bk9gz60mfpygLR X-Google-Smtp-Source: AMrXdXufeIryv/+wmOhoHiLlF7VyA1zwsEqZrw3UqxtqWxQVxu7Ataw4ysNVLY0iZbrku9dbnV3Egg== X-Received: by 2002:a05:600c:1c9d:b0:3d1:f3eb:c718 with SMTP id k29-20020a05600c1c9d00b003d1f3ebc718mr41805642wms.19.1672835248583; Wed, 04 Jan 2023 04:27:28 -0800 (PST) Received: from [192.168.30.216] ([81.0.6.76]) by smtp.gmail.com with ESMTPSA id ay39-20020a05600c1e2700b003cfa80443a0sm45476460wmb.35.2023.01.04.04.27.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Jan 2023 04:27:28 -0800 (PST) Message-ID: Date: Wed, 4 Jan 2023 13:27:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH] acpi: cpuhp: fix guest-visible maximum access size to the legacy reg block Content-Language: en-US To: Igor Mammedov Cc: Laszlo Ersek , qemu devel list , "Michael S. Tsirkin" , Ani Sinha , Ard Biesheuvel , Paolo Bonzini , Peter Maydell , qemu-stable@nongnu.org, Zhu Guihua , Gu Zheng , Li Zhijian References: <20230104090138.214862-1-lersek@redhat.com> <20230104113822.35d23254@imammedo.users.ipa.redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <20230104113822.35d23254@imammedo.users.ipa.redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::32d; envelope-from=philmd@linaro.org; helo=mail-wm1-x32d.google.com X-Spam_score_int: -37 X-Spam_score: -3.8 X-Spam_bar: --- X-Spam_report: (-3.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-1.708, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 4/1/23 11:38, Igor Mammedov wrote: > On Wed, 4 Jan 2023 10:34:09 +0100 > Philippe Mathieu-Daudé wrote: > >> On 4/1/23 10:01, Laszlo Ersek wrote: > [...] >>> diff --git a/hw/acpi/cpu_hotplug.c b/hw/acpi/cpu_hotplug.c >>> index 53654f863830..ff14c3f4106f 100644 >>> --- a/hw/acpi/cpu_hotplug.c >>> +++ b/hw/acpi/cpu_hotplug.c >>> @@ -52,6 +52,9 @@ static const MemoryRegionOps AcpiCpuHotplug_ops = { >>> .endianness = DEVICE_LITTLE_ENDIAN, >>> .valid = { >>> .min_access_size = 1, >>> + .max_access_size = 4, >>> + }, >>> + .impl = { >>> .max_access_size = 1, >> >> Arguably: >> Fixes: b8622725cf ("acpi_piix4: Add infrastructure to send CPU hot-plug >> GPE to guest") > > nope, this one is correct, as legacy interface used 1 byte access only Yes, Laszlo explained elsewhere in the thread.