From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Xu <peterx@redhat.com>, qemu-devel@nongnu.org
Cc: marcandre.lureau@gmail.com
Subject: Re: [Qemu-devel] [PATCH v2 1/2] memory: provide common macros for mtree_print_mr()
Date: Wed, 11 Jan 2017 18:21:46 +0100 [thread overview]
Message-ID: <f6e71117-81ce-db81-d469-d0b48b7cc794@redhat.com> (raw)
In-Reply-To: <1482307137-5106-2-git-send-email-peterx@redhat.com>
On 21/12/2016 08:58, Peter Xu wrote:
> - mr->romd_mode ? 'R' : '-',
> - !mr->readonly && !(mr->rom_device && mr->romd_mode) ? 'W'
> - : '-',
> + MR_CHAR_RD(mr),
> + MR_CHAR_WR(mr),
An alternative definition could be
memory_access_is_direct(mr, false) ? 'R' : '-'
memory_access_is_direct(mr, true) ? 'W' : '-'
for MR_CHAR_RD and MR_CHAR_WR. With this change, I think the small code
duplication in the "? :" operator is tolerable and the code is clearer.
Paolo
next prev parent reply other threads:[~2017-01-11 17:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-21 7:58 [Qemu-devel] [PATCH v2 0/2] memory: extend "info mtree" with flat view dump Peter Xu
2016-12-21 7:58 ` [Qemu-devel] [PATCH v2 1/2] memory: provide common macros for mtree_print_mr() Peter Xu
2017-01-11 17:21 ` Paolo Bonzini [this message]
2017-01-12 5:50 ` Peter Xu
2017-01-12 8:54 ` Paolo Bonzini
2017-01-12 9:46 ` Peter Xu
2017-01-12 11:19 ` Paolo Bonzini
2017-01-12 13:09 ` Peter Xu
2016-12-21 7:58 ` [Qemu-devel] [PATCH v2 2/2] memory: hmp: dump flat view for 'info mtree' Peter Xu
2017-01-11 17:13 ` Paolo Bonzini
2017-01-12 5:53 ` Peter Xu
2017-01-11 6:20 ` [Qemu-devel] [PATCH v2 0/2] memory: extend "info mtree" with flat view dump Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6e71117-81ce-db81-d469-d0b48b7cc794@redhat.com \
--to=pbonzini@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).