From: Paolo Bonzini <pbonzini@redhat.com>
To: Markus Armbruster <armbru@redhat.com>,
"Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
Cc: qemu-devel@nongnu.org, peter.maydell@linaro.org
Subject: Re: [Qemu-devel] [PATCH 2/2] test-vmstate: Silence expected errors
Date: Mon, 24 Oct 2016 15:00:43 +0200 [thread overview]
Message-ID: <f6fe6e61-a679-518a-7232-6e5605b4306e@redhat.com> (raw)
In-Reply-To: <8737jlgb4b.fsf@dusky.pond.sub.org>
On 24/10/2016 14:55, Markus Armbruster wrote:
> Works. My autopilot would do
>
> old_mon = cur_mon;
> cur_mon = &stubs_silent_monitor;
>
> ...
>
> cur_mon = old_mon
>
> because it avoids making assumptions on cur_mon's value. Pick what you
> like better.
I don't think we should rely on a monitor. The assertion here is that
there was no error_report.
Paolo
next prev parent reply other threads:[~2016-10-24 13:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-20 10:36 [Qemu-devel] [PATCH 0/2] Silence test-vmstate errors Dr. David Alan Gilbert (git)
2016-10-20 10:36 ` [Qemu-devel] [PATCH 1/2] tests/stubs: Add a dummy, silent monitor Dr. David Alan Gilbert (git)
2016-10-20 14:24 ` Eric Blake
2016-10-20 10:36 ` [Qemu-devel] [PATCH 2/2] test-vmstate: Silence expected errors Dr. David Alan Gilbert (git)
2016-10-24 12:55 ` Markus Armbruster
2016-10-24 13:00 ` Paolo Bonzini [this message]
2016-10-24 12:59 ` [Qemu-devel] [PATCH 0/2] Silence test-vmstate errors Markus Armbruster
2016-10-24 13:07 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6fe6e61-a679-518a-7232-6e5605b4306e@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).