qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH 00/23] VGA cleanup
@ 2009-08-31 14:07 Juan Quintela
  2009-08-31 14:07 ` [Qemu-devel] [PATCH 01/23] vga: remove useless cast from void * Juan Quintela
                   ` (23 more replies)
  0 siblings, 24 replies; 29+ messages in thread
From: Juan Quintela @ 2009-08-31 14:07 UTC (permalink / raw)
  To: qemu-devel; +Cc: aliguori

This patch:
- cleans the differences between VGAState/VGACommon state
- moves vga pci, isa, isa-mm out of vga.c (cirrus and blizzar uses
  VGA common state).
- Cleans all the cirrus_hook_* stuff is something that don't look like a hook :)

I would want this bits morged/reviewed before going the rest of the cleanup:

Todo:
- vga_ioport_read/write and cirrus_vga_ioport_read/write are almost identical
  after this series of changes.  Creating read/write() callbacks for
  sr/gr/cr/palette.  Should put us there.  The cirrus ones were the difficult ones,
  the vga ones are trivial.
- CONFIG_VBE_BOCHS code.  This code is only used by vga std (pci + isa).  Neither
  cirrus/blizzard/isa-mm uses it.  It should be moved out of vga.c, vga-std.c?, and
  then used by vga-isa and vga-pci?
- vmware_vga: it uses vga as embeded, but it don't save its state, I am not sure
  if it wants/need VBE_BOCHS, ....  I haven't looked at vmware_vga too much, just
  to vga and cirrus_vga.

Comments?

Later, Juan.


Juan Quintela (23):
  vga: remove useless cast from void *
  cirrus_vga: prefix vga_ioport_{read,write} with cirrus
  vga: export vga_ioport_{read,write}
  vga: split vga_{load,save} into pci and common parts
  vga: split pci bits into vga-pci.c
  vga: split isa bits inco vga-isa.c
  vga: export vga_mem_{read,write}
  vga: split vga-isa-mm.o
  vga and cirrus_vga: create vga_ioport_invalid() and use it everywhere
  cirrus_vga: Add a VGACommonState local var to
    cirrus_vga_ioport_{read,write}
  vga: change tabs to spaces
  cirrus_vga: make cirrus_read_hidden_dac() return its result
  vga and cirrus_vga: substitute switch for equivalent assigntment
  vga: Rename last VGAState occurrences to VGACommonState
  cirrus_vga: rename cirrus_hook_read_sr() cirrus_vga_read_sr()
  cirrus_vga: rename cirrus_hook_write_sr() cirrus_vga_write_sr()
  cirrus_vga: rename cirrus_hook_read_palette()
    cirrus_vga_read_palette()
  cirrus_vga: rename cirrus_hook_write_palette()
    cirrus_vga_write_palette()
  cirrus_vga: rename cirrus_hook_read_gr() cirrus_vga_read_gr()
  cirrus_vga: rename cirrus_hook_write_gr() cirrus_vga_write_gr()
  cirrus_vga: rename cirrus_hook_read_cr() cirrus_vga_read_cr()
  cirrus_vga: rename cirrus_hook_write_cr() cirrus_vga_write_cr()
  cirrus_vga: CIRRUS_HOOK_* is not used anymore

 Makefile.target   |    9 +-
 hw/cirrus_vga.c   |  532 +++++++++++++++++++++++-----------------------------
 hw/vga-isa-mm.c   |  130 +++++++++++++
 hw/vga-isa.c      |   50 +++++
 hw/vga-pci.c      |  164 ++++++++++++++++
 hw/vga.c          |  357 ++++++------------------------------
 hw/vga_int.h      |   10 +-
 hw/vga_template.h |   20 +-
 hw/vmware_vga.c   |    1 +
 9 files changed, 662 insertions(+), 611 deletions(-)
 create mode 100644 hw/vga-isa-mm.c
 create mode 100644 hw/vga-isa.c
 create mode 100644 hw/vga-pci.c

^ permalink raw reply	[flat|nested] 29+ messages in thread

end of thread, other threads:[~2009-09-16 14:21 UTC | newest]

Thread overview: 29+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-08-31 14:07 [Qemu-devel] [PATCH 00/23] VGA cleanup Juan Quintela
2009-08-31 14:07 ` [Qemu-devel] [PATCH 01/23] vga: remove useless cast from void * Juan Quintela
2009-08-31 14:07 ` [Qemu-devel] [PATCH 02/23] cirrus_vga: prefix vga_ioport_{read, write} with cirrus Juan Quintela
2009-08-31 14:07 ` [Qemu-devel] [PATCH 03/23] vga: export vga_ioport_{read,write} Juan Quintela
2009-08-31 14:07 ` [Qemu-devel] [PATCH 04/23] vga: split vga_{load, save} into pci and common parts Juan Quintela
2009-08-31 14:07 ` [Qemu-devel] [PATCH 05/23] vga: split pci bits into vga-pci.c Juan Quintela
2009-08-31 14:07 ` [Qemu-devel] [PATCH 06/23] vga: split isa bits inco vga-isa.c Juan Quintela
2009-08-31 14:07 ` [Qemu-devel] [PATCH 07/23] vga: export vga_mem_{read,write} Juan Quintela
2009-08-31 14:07 ` [Qemu-devel] [PATCH 08/23] vga: split vga-isa-mm.o Juan Quintela
2009-08-31 14:07 ` [Qemu-devel] [PATCH 09/23] vga and cirrus_vga: create vga_ioport_invalid() and use it everywhere Juan Quintela
2009-08-31 14:07 ` [Qemu-devel] [PATCH 10/23] cirrus_vga: Add a VGACommonState local var to cirrus_vga_ioport_{read, write} Juan Quintela
2009-08-31 14:07 ` [Qemu-devel] [PATCH 11/23] vga: change tabs to spaces Juan Quintela
2009-08-31 14:07 ` [Qemu-devel] [PATCH 12/23] cirrus_vga: make cirrus_read_hidden_dac() return its result Juan Quintela
2009-08-31 14:07 ` [Qemu-devel] [PATCH 13/23] vga and cirrus_vga: substitute switch for equivalent assigntment Juan Quintela
2009-08-31 14:07 ` [Qemu-devel] [PATCH 14/23] vga: Rename last VGAState occurrences to VGACommonState Juan Quintela
2009-08-31 14:07 ` [Qemu-devel] [PATCH 15/23] cirrus_vga: rename cirrus_hook_read_sr() cirrus_vga_read_sr() Juan Quintela
2009-08-31 14:07 ` [Qemu-devel] [PATCH 16/23] cirrus_vga: rename cirrus_hook_write_sr() cirrus_vga_write_sr() Juan Quintela
2009-08-31 14:07 ` [Qemu-devel] [PATCH 17/23] cirrus_vga: rename cirrus_hook_read_palette() cirrus_vga_read_palette() Juan Quintela
2009-08-31 14:07 ` [Qemu-devel] [PATCH 18/23] cirrus_vga: rename cirrus_hook_write_palette() cirrus_vga_write_palette() Juan Quintela
2009-08-31 14:07 ` [Qemu-devel] [PATCH 19/23] cirrus_vga: rename cirrus_hook_read_gr() cirrus_vga_read_gr() Juan Quintela
2009-08-31 14:07 ` [Qemu-devel] [PATCH 20/23] cirrus_vga: rename cirrus_hook_write_gr() cirrus_vga_write_gr() Juan Quintela
2009-08-31 14:07 ` [Qemu-devel] [PATCH 21/23] cirrus_vga: rename cirrus_hook_read_cr() cirrus_vga_read_cr() Juan Quintela
2009-08-31 14:07 ` [Qemu-devel] [PATCH 22/23] cirrus_vga: rename cirrus_hook_write_cr() cirrus_vga_write_cr() Juan Quintela
2009-08-31 14:07 ` [Qemu-devel] [PATCH 23/23] cirrus_vga: CIRRUS_HOOK_* is not used anymore Juan Quintela
2009-09-16 12:43 ` [Qemu-devel] [PATCH 00/23] VGA cleanup Pierre Riteau
2009-09-16 12:52   ` [Qemu-devel] " Juan Quintela
2009-09-16 13:17     ` Pierre Riteau
2009-09-16 13:45       ` Juan Quintela
2009-09-16 14:21         ` Pierre Riteau

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).