From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org
Cc: fam@euphon.net, peter.maydell@linaro.org,
sheepdog@lists.wpkg.org, sagark@eecs.berkeley.edu,
david@redhat.com, jasowang@redhat.com, yuval.shaia.ml@gmail.com,
armbru@redhat.com, jcmvbkbc@gmail.com, Alistair.Francis@wdc.com,
kraxel@redhat.com, chenhc@lemote.com, jslaby@suse.cz,
sstabellini@kernel.org, berto@igalia.com, kvm@vger.kernel.org,
ysato@users.sourceforge.jp, quintela@redhat.com, mst@redhat.com,
mdroth@linux.vnet.ibm.com, pasic@linux.ibm.com,
borntraeger@de.ibm.com, aleksandar.qemu.devel@gmail.com,
anthony.perard@citrix.com, marcandre.lureau@redhat.com,
rth@twiddle.net, mjrosato@linux.ibm.com, thuth@redhat.com,
ehabkost@redhat.com, sw@weilnetz.de, pl@kamp.de,
dgilbert@redhat.com, paul@xen.org, qemu-s390x@nongnu.org,
qemu-arm@nongnu.org, namei.unix@gmail.com, berrange@redhat.com,
sunilmut@microsoft.com, jsnow@redhat.com,
zhang.zhanghailiang@huawei.com, kwolf@redhat.com,
qemu-riscv@nongnu.org, qemu-block@nongnu.org,
kbastian@mail.uni-paderborn.de, cohuck@redhat.com,
laurent@vivier.eu, mreitz@redhat.com, palmer@dabbelt.com,
pbonzini@redhat.com, xen-devel@lists.xenproject.org,
aleksandar.rikalo@syrmia.com, aurelien@aurel32.net
Subject: Re: [PATCH] qemu/atomic.h: prefix qemu_ to solve <stdatomic.h> collisions
Date: Tue, 22 Sep 2020 10:33:44 +0200 [thread overview]
Message-ID: <f70c3ae8-330f-af43-0005-86b4d3fabb2e@redhat.com> (raw)
In-Reply-To: <20200922081705.GB201611@stefanha-x1.localdomain>
On 9/22/20 10:17 AM, Stefan Hajnoczi wrote:
> On Mon, Sep 21, 2020 at 01:56:08PM -0700, no-reply@patchew.org wrote:
>> ERROR: Macros with multiple statements should be enclosed in a do - while loop
>> #2968: FILE: include/qemu/atomic.h:152:
>> +#define qemu_atomic_rcu_read__nocheck(ptr, valptr) \
>> __atomic_load(ptr, valptr, __ATOMIC_RELAXED); \
>> smp_read_barrier_depends();
>>
...
>> WARNING: Block comments use a leading /* on a separate line
>> #7456: FILE: util/rcu.c:154:
>> + /* In either case, the qemu_atomic_mb_set below blocks stores that free
>>
>> total: 7 errors, 4 warnings, 6507 lines checked
>
> These are pre-existing coding style issues. This is a big patch that
> tries to make as few actual changes as possible so I would rather not
> try to fix them.
What I do with automated patches triggering checkpatch errors:
- run automated conversion
- fix errors until checkpatch is happy
- run automated conversion inversed
- result is the checkpatch changes, commit them
- run automated conversion again, commit
next prev parent reply other threads:[~2020-09-22 8:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-21 16:23 [PATCH] qemu/atomic.h: prefix qemu_ to solve <stdatomic.h> collisions Stefan Hajnoczi
2020-09-21 20:56 ` no-reply
2020-09-22 8:17 ` Stefan Hajnoczi
2020-09-22 8:33 ` Philippe Mathieu-Daudé [this message]
2020-09-21 21:29 ` Eric Blake
2020-09-22 9:05 ` Stefan Hajnoczi
2020-09-22 6:27 ` Paolo Bonzini
2020-09-22 6:45 ` David Hildenbrand
2020-09-22 6:56 ` Paolo Bonzini
2020-09-22 7:45 ` David Hildenbrand
2020-09-22 8:18 ` Daniel P. Berrangé
2020-09-23 9:14 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f70c3ae8-330f-af43-0005-86b4d3fabb2e@redhat.com \
--to=philmd@redhat.com \
--cc=Alistair.Francis@wdc.com \
--cc=aleksandar.qemu.devel@gmail.com \
--cc=aleksandar.rikalo@syrmia.com \
--cc=anthony.perard@citrix.com \
--cc=armbru@redhat.com \
--cc=aurelien@aurel32.net \
--cc=berrange@redhat.com \
--cc=berto@igalia.com \
--cc=borntraeger@de.ibm.com \
--cc=chenhc@lemote.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=dgilbert@redhat.com \
--cc=ehabkost@redhat.com \
--cc=fam@euphon.net \
--cc=jasowang@redhat.com \
--cc=jcmvbkbc@gmail.com \
--cc=jslaby@suse.cz \
--cc=jsnow@redhat.com \
--cc=kbastian@mail.uni-paderborn.de \
--cc=kraxel@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kwolf@redhat.com \
--cc=laurent@vivier.eu \
--cc=marcandre.lureau@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=mjrosato@linux.ibm.com \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=namei.unix@gmail.com \
--cc=palmer@dabbelt.com \
--cc=pasic@linux.ibm.com \
--cc=paul@xen.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=pl@kamp.de \
--cc=qemu-arm@nongnu.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=quintela@redhat.com \
--cc=rth@twiddle.net \
--cc=sagark@eecs.berkeley.edu \
--cc=sheepdog@lists.wpkg.org \
--cc=sstabellini@kernel.org \
--cc=stefanha@redhat.com \
--cc=sunilmut@microsoft.com \
--cc=sw@weilnetz.de \
--cc=thuth@redhat.com \
--cc=xen-devel@lists.xenproject.org \
--cc=ysato@users.sourceforge.jp \
--cc=yuval.shaia.ml@gmail.com \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).