From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 32D6EC5472F for ; Mon, 26 Aug 2024 18:51:09 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sienY-00036K-3Q; Mon, 26 Aug 2024 14:50:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sienW-00033x-1j; Mon, 26 Aug 2024 14:50:38 -0400 Received: from mail-pg1-x52b.google.com ([2607:f8b0:4864:20::52b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sienU-0002c1-5I; Mon, 26 Aug 2024 14:50:37 -0400 Received: by mail-pg1-x52b.google.com with SMTP id 41be03b00d2f7-7cd8d2731d1so3027032a12.3; Mon, 26 Aug 2024 11:50:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724698234; x=1725303034; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=uN7Ouh8wAxBLso2lghLmbeZEpkJeIB3VO1B/lvg7eP0=; b=QUZ3MGbfT0e36HC0SxCYZnMJ3YSQIWyJusXU3ETO4vpcEIduEWr3w0K2M3cZc4mjdp wTkFWq/uYxDv+IctmrswyiWG1+++js2t4ydrYfWw4vqDBEBOWPzC5RQn6JscqTRMbpQl f6dyc31oGnqAdsq87Arn7ZZ7R3py1JE37dGhNejiSizLrfNBOcUVv8DNs+EPaqH3uqyZ 5z27TpldjBlx7LGn3zEtTt3+EZKeFfPNU5iXBvdbnubT7oeSfqaluGRc5K5IE41aOXSM jJvXFOlkEyg/URK+DGbTlJgLqM5JTNiU2ssAi+CNRk+kZ6+IoF11IKI1iYIpVm6Xw4RL WBvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724698234; x=1725303034; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=uN7Ouh8wAxBLso2lghLmbeZEpkJeIB3VO1B/lvg7eP0=; b=BOfUattwhOeO/1rYtwdIAarh4cQE2BvC5c0m48vVISmin0jN+a7VeCTmFzwEO7W6QB KsKe0k3gH1Bt91hLHv+vaP+6xNXpyuKlaTgMWrfHj1uPeATmTJ2vrVCuIoxoT8VzB2Vy OWp/k40m4diblquQ+mPAP6ROnEJhm+wy30/UV0uT/FTGbVw6Q5giShDQviLfP817YDuu 4FMcb4QEzNpcP8w0/4CCVaGFl8SLQslSIzJI6MESu26jp/UjOPyNxM36M3ROASdcPARm Z86jBLXBVfQ5PUey8gYeUpw8MrUIQdpcsFUxutZ1QC2ZtnexvVB4RY33EH1zZ1gx2Sjq QyJg== X-Forwarded-Encrypted: i=1; AJvYcCVsj1uXom74rAZNRQKJH7dKGDeXUnpiDa0vbWDkF63o6UWFkgYjZlKGbQ6b3iSRi12oQTbho+A7HEzt@nongnu.org X-Gm-Message-State: AOJu0YwmUoyqYnVC5nTlrzUllGyPGYO7mVdXqawV75waZf3VmHXEvFQx DXfATbiSu5wQWzipDcxez5Bz85talkrJpN9TiuVQv8POQ98D6KV03MMj+A== X-Google-Smtp-Source: AGHT+IEAXX6HgrgHDLB0FI9+oVkD8ql0Fv5q3QQxdkMGuoE9GExlg78k9VdC1WMqbPlQ6WVrYRdS6A== X-Received: by 2002:a17:90b:1bc9:b0:2cf:2ab6:a157 with SMTP id 98e67ed59e1d1-2d646bcc7demr10173059a91.12.1724698233636; Mon, 26 Aug 2024 11:50:33 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:329c:23ff:fee3:9d7c? ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2d613919fd2sm10352184a91.13.2024.08.26.11.50.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Aug 2024 11:50:33 -0700 (PDT) Message-ID: Date: Mon, 26 Aug 2024 11:50:31 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] aspeed: Deprecate the tacoma-bmc machine To: =?UTF-8?Q?C=C3=A9dric_Le_Goater?= Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org, Peter Maydell , Joel Stanley , Andrew Jeffery , =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= References: <20240625070830.492251-1-clg@redhat.com> <4e04f930-e7af-4084-99a8-2a3139e2bf43@roeck-us.net> <5fb7342b-fa67-4cb2-b6fd-2241b7b76d03@redhat.com> Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAlVcphcFCRmg06EACgkQyx8mb86fmYFg0RAA nzXJzuPkLJaOmSIzPAqqnutACchT/meCOgMEpS5oLf6xn5ySZkl23OxuhpMZTVX+49c9pvBx hpvl5bCWFu5qC1jC2eWRYU+aZZE4sxMaAGeWenQJsiG9lP8wkfCJP3ockNu0ZXXAXwIbY1O1 c+l11zQkZw89zNgWgKobKzrDMBFOYtAh0pAInZ9TSn7oA4Ctejouo5wUugmk8MrDtUVXmEA9 7f9fgKYSwl/H7dfKKsS1bDOpyJlqhEAH94BHJdK/b1tzwJCFAXFhMlmlbYEk8kWjcxQgDWMu GAthQzSuAyhqyZwFcOlMCNbAcTSQawSo3B9yM9mHJne5RrAbVz4TWLnEaX8gA5xK3uCNCeyI sqYuzA4OzcMwnnTASvzsGZoYHTFP3DQwf2nzxD6yBGCfwNGIYfS0i8YN8XcBgEcDFMWpOQhT Pu3HeztMnF3HXrc0t7e5rDW9zCh3k2PA6D2NV4fews9KDFhLlTfCVzf0PS1dRVVWM+4jVl6l HRIAgWp+2/f8dx5vPc4Ycp4IsZN0l1h9uT7qm1KTwz+sSl1zOqKD/BpfGNZfLRRxrXthvvY8 BltcuZ4+PGFTcRkMytUbMDFMF9Cjd2W9dXD35PEtvj8wnEyzIos8bbgtLrGTv/SYhmPpahJA l8hPhYvmAvpOmusUUyB30StsHIU2LLccUPPOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAlVcpi8FCRmg08MACgkQyx8mb86fmYHNRQ/+ J0OZsBYP4leJvQF8lx9zif+v4ZY/6C9tTcUv/KNAE5leyrD4IKbnV4PnbrVhjq861it/zRQW cFpWQszZyWRwNPWUUz7ejmm9lAwPbr8xWT4qMSA43VKQ7ZCeTQJ4TC8kjqtcbw41SjkjrcTG wF52zFO4bOWyovVAPncvV9eGA/vtnd3xEZXQiSt91kBSqK28yjxAqK/c3G6i7IX2rg6pzgqh hiH3/1qM2M/LSuqAv0Rwrt/k+pZXE+B4Ud42hwmMr0TfhNxG+X7YKvjKC+SjPjqp0CaztQ0H nsDLSLElVROxCd9m8CAUuHplgmR3seYCOrT4jriMFBtKNPtj2EE4DNV4s7k0Zy+6iRQ8G8ng QjsSqYJx8iAR8JRB7Gm2rQOMv8lSRdjva++GT0VLXtHULdlzg8VjDnFZ3lfz5PWEOeIMk7Rj trjv82EZtrhLuLjHRCaG50OOm0hwPSk1J64R8O3HjSLdertmw7eyAYOo4RuWJguYMg5DRnBk WkRwrSuCn7UG+qVWZeKEsFKFOkynOs3pVbcbq1pxbhk3TRWCGRU5JolI4ohy/7JV1TVbjiDI HP/aVnm6NC8of26P40Pg8EdAhajZnHHjA7FrJXsy3cyIGqvg9os4rNkUWmrCfLLsZDHD8FnU mDW4+i+XlNFUPUYMrIKi9joBhu18ssf5i5Q= In-Reply-To: <5fb7342b-fa67-4cb2-b6fd-2241b7b76d03@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::52b; envelope-from=groeck7@gmail.com; helo=mail-pg1-x52b.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Hi, On 8/26/24 02:58, Cédric Le Goater wrote: > Hello Guenter, > > On 8/9/24 00:05, Guenter Roeck wrote: >> Hi, >> >> On Tue, Jun 25, 2024 at 09:08:30AM +0200, Cédric Le Goater wrote: >>> The tacoma-bmc machine was a board including an AST2600 SoC based BMC >>> and a witherspoon like OpenPOWER system. It was used for bring up of >>> the AST2600 SoC in labs. It can be easily replaced by the rainier-bmc >>> machine which is part of a real product offering. >>> >>> Signed-off-by: Cédric Le Goater >> >> I have been using tacoma-bmc to test tcg,tpm-tis-i2c functionality >> on arm. rainier-bmc doesn't support that, and other IBM BMCs which >> do support it (bonnell, everest, system1) are not supported in qemu. >> >> Do you have a suggested alternative ? > > Could you use the ast2600-evb machine instead ? as done in > machine_aspeed.py, see routine test_arm_ast2600_evb_buildroot_tpm. > Unfortunately, that does not work for me because that requires instantiating the tpm chip from the CLI by writing into the new_device sysfs attribute, and I can not do that in my test environment. > We can't add a "tpm-tis-i2c" device to the tacoma-bmc machine init > routine because a TPM backend is required. > Not sure I understand; tacoma-bmc instantiates the TPM chip through its devicetree file which is what I was looking for. I solved the problem by adding support for IBM Bonnell (which instantiates the TPM chip through its devicetree file, similar to tacoma-bmc) to my local copy of qemu. It isn't perfect since I don't know the correct HW pin strapping and reused the strapping from Rainier, but it works for me. Thanks, Guenter