From: Stefan Berger <stefanb@linux.vnet.ibm.com>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Cc: amarnath valluri <amarnath.valluri@intel.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 00/42] TPM: code cleanup & CRB device
Date: Thu, 19 Oct 2017 12:50:31 -0400 [thread overview]
Message-ID: <f70e846f-fd53-93ad-6cd8-84fbb0960e39@linux.vnet.ibm.com> (raw)
In-Reply-To: <6b6eb9ff-b9de-7480-3f0d-ee2e7b5ab3b1@linux.vnet.ibm.com>
On 10/19/2017 10:44 AM, Stefan Berger wrote:
> On 10/19/2017 10:33 AM, Marc-André Lureau wrote:
>> Hi Stefan
>>
>> ----- Original Message -----
>>> On 10/09/2017 06:55 PM, Marc-André Lureau wrote:
>>>> Hi,
>>>>
>>>> I accumulated a series of patch doing some TPM code cleanup while
>>>> doing review. I removed some dead code, simplified other parts, and
>>>> tried to isolate implementation of the backend and frontend by using a
>>>> new TPMIf interface. I solved a few issues, and added some FIXME for
>>>> what should be tackled. Finally, I implemented a simple CRB device
>>>> (tpm 2.0) that is work in progress for now - it works fine with
>>>> passthrough, but swtpm/libtpms with win10 has some issues that need
>>>> more investigations.
>>>>
>>>> seabios CRB support is required for TPM 2.0 & emulation
>>>> (https://mail.coreboot.org/pipermail/seabios/2017-October/011839.html)
>>>>
>>>> Comments/review welcome!
>>> Are you going to post a v2 soon?
>> I was wondering if you would take the patches that you already
>> reviewed for the next pull request. That way v2 would be smaller.
>
> I'll take them up to 21/42.
Tested them and it seems to work fine. I'll post later today.
Did you have any more luck with win10 and tpm2 ?
Stefan
next prev parent reply other threads:[~2017-10-19 16:50 UTC|newest]
Thread overview: 116+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-09 22:55 [Qemu-devel] [PATCH 00/42] TPM: code cleanup & CRB device Marc-André Lureau
2017-10-09 22:55 ` [Qemu-devel] [PATCH 01/42] tpm-tis: remove unused hw_access argument Marc-André Lureau
2017-10-10 2:34 ` Stefan Berger
2017-10-09 22:55 ` [Qemu-devel] [PATCH 02/42] tpm-tis: remove RAISE_STS_IRQ Marc-André Lureau
2017-10-10 2:36 ` Stefan Berger
2017-10-09 22:55 ` [Qemu-devel] [PATCH 03/42] tpm: make tpm_get_backend_driver() static Marc-André Lureau
2017-10-10 2:36 ` Stefan Berger
2017-10-09 22:55 ` [Qemu-devel] [PATCH 04/42] tpm: lookup tpm backend class in tpm_driver_find_by_type() Marc-André Lureau
2017-10-10 2:38 ` Stefan Berger
2017-10-09 22:55 ` [Qemu-devel] [PATCH 05/42] tpm: replace tpm_get_backend_driver() to drop be_drivers Marc-André Lureau
2017-10-10 2:40 ` Stefan Berger
2017-10-09 22:55 ` [Qemu-devel] [PATCH 06/42] tpm: remove tpm_register_driver() Marc-André Lureau
2017-10-10 2:41 ` Stefan Berger
2017-10-09 22:55 ` [Qemu-devel] [PATCH 07/42] tpm: move TPMSizedBuffer to tpm_tis.h Marc-André Lureau
2017-10-10 2:41 ` Stefan Berger
2017-10-09 22:55 ` [Qemu-devel] [PATCH 08/42] tpm: remove TPMDriverOps Marc-André Lureau
2017-10-10 7:12 ` Valluri, Amarnath
2017-10-10 7:29 ` Valluri, Amarnath
2017-10-19 14:43 ` Stefan Berger
2017-10-09 22:55 ` [Qemu-devel] [PATCH 09/42] tpm: remove init() class method Marc-André Lureau
2017-10-10 15:30 ` Stefan Berger
2017-10-09 22:55 ` [Qemu-devel] [PATCH 10/42] tpm: remove configure_tpm() hop Marc-André Lureau
2017-10-10 15:31 ` Stefan Berger
2017-10-09 22:55 ` [Qemu-devel] [PATCH 11/42] tpm: remove unused TPMBackendCmd Marc-André Lureau
2017-10-19 14:39 ` Stefan Berger
2017-10-09 22:55 ` [Qemu-devel] [PATCH 12/42] tpm: remove needless cast Marc-André Lureau
2017-10-10 15:31 ` Stefan Berger
2017-10-09 22:55 ` [Qemu-devel] [PATCH 13/42] tpm: remove locty argument from receive_cb Marc-André Lureau
2017-10-10 15:32 ` Stefan Berger
2017-10-09 22:55 ` [Qemu-devel] [PATCH 14/42] tpm: add TPMBackendCmd to hold the request state Marc-André Lureau
2017-10-10 15:38 ` Stefan Berger
2017-10-10 16:16 ` Marc-André Lureau
2017-10-11 1:27 ` Stefan Berger
2017-10-09 22:55 ` [Qemu-devel] [PATCH 15/42] tpm-emulator: fix error handling Marc-André Lureau
2017-10-10 15:39 ` Stefan Berger
2017-10-09 22:55 ` [Qemu-devel] [PATCH 16/42] tpm: remove locty_data from TPMState Marc-André Lureau
2017-10-10 15:42 ` Stefan Berger
2017-10-09 22:55 ` [Qemu-devel] [PATCH 17/42] tpm-tis: move TPMState to TIS header Marc-André Lureau
2017-10-10 15:45 ` Stefan Berger
2017-10-10 16:01 ` Marc-André Lureau
2017-10-09 22:55 ` [Qemu-devel] [PATCH 18/42] tpm-tis: remove tpm_tis.h header Marc-André Lureau
2017-10-10 18:03 ` Stefan Berger
2017-10-09 22:56 ` [Qemu-devel] [PATCH 19/42] tpm-tis: fold TPMTISEmuState in TPMState Marc-André Lureau
2017-10-10 18:07 ` Stefan Berger
2017-10-09 22:56 ` [Qemu-devel] [PATCH 20/42] tpm: add a QOM TPM interface Marc-André Lureau
2017-10-10 18:09 ` Stefan Berger
2017-10-09 22:56 ` [Qemu-devel] [PATCH 21/42] tpm: move recv_data_callback to " Marc-André Lureau
2017-10-10 20:17 ` Stefan Berger
2017-10-09 22:56 ` [Qemu-devel] [PATCH 22/42] tpm-backend: store TPMIf interface, improve backend_init() Marc-André Lureau
2017-10-10 8:18 ` Valluri, Amarnath
2017-10-10 11:02 ` Marc-André Lureau
2017-10-09 22:56 ` [Qemu-devel] [PATCH 23/42] tpm-tis: no longer expose TPMState Marc-André Lureau
2017-10-10 20:17 ` Stefan Berger
2017-10-09 22:56 ` [Qemu-devel] [PATCH 24/42] tpm-be: call request_completed() out of thread Marc-André Lureau
2017-10-19 14:35 ` Stefan Berger
2017-10-19 22:02 ` Stefan Berger
2017-10-19 23:21 ` Stefan Berger
2017-10-09 22:56 ` [Qemu-devel] [PATCH 25/42] tpm-be: report error instead of front-end Marc-André Lureau
2017-10-10 20:20 ` Stefan Berger
2017-10-09 22:56 ` [Qemu-devel] [PATCH 26/42] tpm-be: ask model to the TPM interface Marc-André Lureau
2017-10-10 20:22 ` Stefan Berger
2017-10-09 22:56 ` [Qemu-devel] [PATCH 27/42] tpm: remove unused opened code Marc-André Lureau
2017-10-10 20:50 ` Stefan Berger
2017-10-10 22:27 ` Marc-André Lureau
2017-10-11 1:30 ` Stefan Berger
2017-10-09 22:56 ` [Qemu-devel] [PATCH 28/42] tpm-passthrough: don't save guessed cancel_path in options Marc-André Lureau
2017-10-10 20:26 ` Stefan Berger
2017-10-09 22:56 ` [Qemu-devel] [PATCH 29/42] tpm-be: update optional function pointers Marc-André Lureau
2017-10-10 20:28 ` Stefan Berger
2017-10-09 22:56 ` [Qemu-devel] [PATCH 30/42] tpm-passthrough: pass TPMPassthruState to handle_device_opts Marc-André Lureau
2017-10-10 20:29 ` Stefan Berger
2017-10-09 22:56 ` [Qemu-devel] [PATCH 31/42] tpm-backend: move set 'id' to common code Marc-André Lureau
2017-10-10 8:15 ` Valluri, Amarnath
2017-10-10 10:47 ` Marc-André Lureau
2017-10-10 11:39 ` Valluri, Amarnath
2017-10-10 20:31 ` Stefan Berger
2017-10-09 22:56 ` [Qemu-devel] [PATCH 32/42] tpm-passthrough: make it safer to destroy after creation Marc-André Lureau
2017-10-10 18:13 ` Stefan Berger
2017-10-09 22:56 ` [Qemu-devel] [PATCH 33/42] tpm-passthrough: remove error cleanup from handle_device_opts Marc-André Lureau
2017-10-10 20:34 ` Stefan Berger
2017-10-10 22:19 ` Marc-André Lureau
2017-10-11 1:28 ` Stefan Berger
2017-10-09 22:56 ` [Qemu-devel] [PATCH 34/42] tpm-passthrough: workaround a possible race Marc-André Lureau
2017-10-10 20:37 ` Stefan Berger
2017-10-09 22:56 ` [Qemu-devel] [PATCH 35/42] tpm-tis: simplify header inclusion Marc-André Lureau
2017-10-10 20:38 ` Stefan Berger
2017-10-09 22:56 ` [Qemu-devel] [PATCH 36/42] tpm: rename qemu_find_tpm() -> qemu_find_tpm_be() Marc-André Lureau
2017-10-10 20:38 ` Stefan Berger
2017-10-09 22:56 ` [Qemu-devel] [PATCH 37/42] tpm: lookup the the TPM interface instead of TIS device Marc-André Lureau
2017-10-10 20:21 ` Eduardo Habkost
2017-10-10 20:47 ` Stefan Berger
2017-10-10 22:31 ` Marc-André Lureau
2017-10-10 20:42 ` Stefan Berger
2017-10-09 22:56 ` [Qemu-devel] [PATCH 38/42] tpm: add TPM interface to lookup TPM version Marc-André Lureau
2017-10-10 20:43 ` Stefan Berger
2017-10-09 22:56 ` [Qemu-devel] [PATCH 39/42] tpm: add tpm_cmd_get_size() to tpm_util Marc-André Lureau
2017-10-10 18:23 ` Stefan Berger
2017-10-09 22:56 ` [Qemu-devel] [PATCH 40/42] acpi: change TPM TIS data conditions Marc-André Lureau
2017-10-10 18:22 ` Stefan Berger
2017-10-09 22:56 ` [Qemu-devel] [PATCH 41/42] tpm-emulator: add a FIXME comment about blocking cancel Marc-André Lureau
2017-10-10 18:21 ` Stefan Berger
2017-10-09 22:56 ` [Qemu-devel] [PATCH 42/42] WIP: add TPM CRB device Marc-André Lureau
2017-10-10 18:28 ` Stefan Berger
2017-10-10 20:19 ` Eduardo Habkost
2017-10-20 15:31 ` Stefan Berger
2017-11-06 17:49 ` Stefan Berger
2017-10-09 23:32 ` [Qemu-devel] [PATCH 00/42] TPM: code cleanup & " no-reply
2017-10-10 2:34 ` Stefan Berger
2017-10-10 12:14 ` Marc-André Lureau
2017-10-10 18:20 ` Stefan Berger
2017-10-19 14:26 ` Stefan Berger
2017-10-19 14:33 ` Marc-André Lureau
2017-10-19 14:44 ` Stefan Berger
2017-10-19 16:50 ` Stefan Berger [this message]
2017-10-19 17:00 ` Marc-André Lureau
2017-10-19 23:55 ` Stefan Berger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f70e846f-fd53-93ad-6cd8-84fbb0960e39@linux.vnet.ibm.com \
--to=stefanb@linux.vnet.ibm.com \
--cc=amarnath.valluri@intel.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).