From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Ard Biesheuvel" <ardb@kernel.org>
Subject: Re: [PATCH for-5.2] target/arm: Fix neon VTBL/VTBX for len > 1
Date: Mon, 9 Nov 2020 08:50:39 -0800 [thread overview]
Message-ID: <f7338191-7185-deef-b928-fe85e158632f@linaro.org> (raw)
In-Reply-To: <CAFEAcA9BSNwtqNwh1H3+SjEAvxihpfcXc=frPLcqNtaKUJi0Yg@mail.gmail.com>
On 11/9/20 3:59 AM, Peter Maydell wrote:
>> + tmp = env->vfp.zregs[reg >> 1].d[reg & 1];
>
> This can be written
> tmp = *aa32_vfp_dreg(env, reg);
> rather than open-coding the conversion from a dreg number into
> the appropriate access into the zregs representation.
Ah, I forgot about that helper. Thanks.
r~
prev parent reply other threads:[~2020-11-09 16:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-05 17:11 [PATCH for-5.2] target/arm: Fix neon VTBL/VTBX for len > 1 Richard Henderson
2020-11-09 11:59 ` Peter Maydell
2020-11-09 16:50 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7338191-7185-deef-b928-fe85e158632f@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=ardb@kernel.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).