From: Paolo Bonzini <pbonzini@redhat.com>
To: John Snow <jsnow@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] List of files containing devices which have not been QOMified
Date: Tue, 6 Nov 2018 22:26:40 +0100 [thread overview]
Message-ID: <f73747fa-0d66-71e1-542e-27953e06c96b@redhat.com> (raw)
In-Reply-To: <454d6ffd-bc43-4f2e-0916-b4c4a14fe788@redhat.com>
On 06/11/2018 22:23, John Snow wrote:
>
>
> On 11/06/2018 02:46 PM, Paolo Bonzini wrote:
>> On 06/11/2018 19:43, Peter Maydell wrote:
>
>>> hw/ide/ahci.c
>>
>> Even though AHCIState is not a QOM object, all of its users are
>> (TYPE_SYSBUS_AHCI is in this file, TYPE_ICH9_AHCI is in hw/ide/ich.c).
>
> Yeah, if there's something *further* that needs to happen, let me know.
> I'm not sure what the QOM ideal is.
I think it's okay. The virtio-*-device approach (which is contained in
virtio-*-pci and virtio-*-ccw) made sense for virtio where you could
have "socket" virtio-mmio devices and the virtio-*-device "plugs" are
specified in the command line. However, for AHCI it's overkill.
Paolo
next prev parent reply other threads:[~2018-11-06 21:28 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-06 18:43 [Qemu-devel] List of files containing devices which have not been QOMified Peter Maydell
2018-11-06 19:16 ` Philippe Mathieu-Daudé
2018-11-06 23:06 ` Peter Maydell
2018-11-07 15:22 ` Philippe Mathieu-Daudé
2018-11-06 19:43 ` Paolo Bonzini
2018-11-06 19:46 ` Paolo Bonzini
2018-11-06 19:51 ` Alistair Francis
2018-11-06 21:23 ` John Snow
2018-11-06 21:26 ` Paolo Bonzini [this message]
2018-11-06 23:05 ` Peter Maydell
2018-11-06 23:09 ` Paolo Bonzini
2018-11-07 18:53 ` Palmer Dabbelt
2018-11-09 10:17 ` Mark Cave-Ayland
2018-11-09 10:31 ` Peter Maydell
2018-11-10 15:20 ` Mark Cave-Ayland
2018-11-12 10:57 ` Peter Maydell
2018-11-09 11:17 ` Gerd Hoffmann
2018-11-09 11:29 ` Gerd Hoffmann
2018-11-09 12:39 ` Thomas Huth
2018-11-09 12:44 ` Peter Maydell
2018-11-09 13:16 ` Paolo Bonzini
2018-11-09 14:03 ` [Qemu-devel] deprecating/removing bluetooth (was: Re: List of files containing devices which have not been QOMified) Gerd Hoffmann
2018-11-12 8:51 ` [Qemu-devel] List of files containing devices which have not been QOMified Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f73747fa-0d66-71e1-542e-27953e06c96b@redhat.com \
--to=pbonzini@redhat.com \
--cc=jsnow@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).