From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47502) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d4BxT-0002ma-DD for qemu-devel@nongnu.org; Fri, 28 Apr 2017 15:53:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d4BxS-0001do-KE for qemu-devel@nongnu.org; Fri, 28 Apr 2017 15:53:39 -0400 References: <20170427014626.11553-1-eblake@redhat.com> <20170427014626.11553-9-eblake@redhat.com> From: Max Reitz Message-ID: Date: Fri, 28 Apr 2017 21:53:29 +0200 MIME-Version: 1.0 In-Reply-To: <20170427014626.11553-9-eblake@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="u3m6dtNtXr8uvJWG4fHN6AI2TfAatcjED" Subject: Re: [Qemu-devel] [PATCH v10 08/17] qemu-io: Switch 'map' output to byte-based reporting List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-devel@nongnu.org Cc: kwolf@redhat.com, qemu-block@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --u3m6dtNtXr8uvJWG4fHN6AI2TfAatcjED From: Max Reitz To: Eric Blake , qemu-devel@nongnu.org Cc: kwolf@redhat.com, qemu-block@nongnu.org Message-ID: Subject: Re: [PATCH v10 08/17] qemu-io: Switch 'map' output to byte-based reporting References: <20170427014626.11553-1-eblake@redhat.com> <20170427014626.11553-9-eblake@redhat.com> In-Reply-To: <20170427014626.11553-9-eblake@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 27.04.2017 03:46, Eric Blake wrote: > Mixing byte offset and sector allocation counts is a bit > confusing. Also, reporting n/m sectors, where m decreases > according to the remaining size of the file, isn't really > adding any useful information. Since this map doesn't leave out any range in the image file -- not really, no. :-) > Update the output to use > byte counts, and adjust the affected tests (./check -qcow2 102, > ./check -vpc 146). >=20 > Signed-off-by: Eric Blake >=20 > --- > v10: rebase to updated test 179 > v9: new patch > --- > qemu-io-cmds.c | 5 ++--- > tests/qemu-iotests/102.out | 4 ++-- > tests/qemu-iotests/146.out | 30 +++++++++++++++--------------- > tests/qemu-iotests/179.out | 22 +++++++++++----------- > 4 files changed, 30 insertions(+), 31 deletions(-) Reviewed-by: Max Reitz --u3m6dtNtXr8uvJWG4fHN6AI2TfAatcjED Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQFGBAEBCAAwFiEEkb62CjDbPohX0Rgp9AfbAGHVz0AFAlkDnbkSHG1yZWl0ekBy ZWRoYXQuY29tAAoJEPQH2wBh1c9A8rsH/35LOsA0sDRXACWUPpIcOVUh+julLlrQ IGw2RwMRAqxSEONw9U5v1slWbqj2Y+EmpmjdEP9gFgQJ8XSsxYgJQOYrmEFPNo1k LB4UC+LP7xJJvyK/b/5eMOzawj2/QRjB5OLXPR8D6XW5y74hxoDSHqZWN6ikMyJw L666VGaRrcRLhAUb5GlCfrhM3hScMrqdtZhjpzUev9PPfr1oqVv5vzdu6+ALgdO4 zecXhoO8pvlpuaw8jKD6abC/kCfYJD8I4BZojyat3ttrXJwsIXJ04qFAyF98/No7 M3X5FvpnerLSUMC6DYICzioUCghcfOAAuqv5k1JtaiZ4N2yrTvOKRZY= =fRKL -----END PGP SIGNATURE----- --u3m6dtNtXr8uvJWG4fHN6AI2TfAatcjED--