From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: "Daniel P. Berrangé" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [PATCH] meson: sort C warning flags alphabetically
Date: Wed, 6 Dec 2023 18:00:47 +0100 [thread overview]
Message-ID: <f73fe5a4-dedc-4013-9b22-7bf25cdd37f1@linaro.org> (raw)
In-Reply-To: <20231206164443.1058339-1-berrange@redhat.com>
On 6/12/23 17:44, Daniel P. Berrangé wrote:
> When scanning the list of warning flags to see if one is present, it is
> helpful if they are in alphabetical order. It is further helpful to
> separate out the 'no-' prefixed warnings.
I was sure this was already done eh...
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>
> The diff looks horrendous, so look at the resulting meson.build to see
> the benefit.
>
> meson.build | 40 +++++++++++++++++++++-------------------
> 1 file changed, 21 insertions(+), 19 deletions(-)
prev parent reply other threads:[~2023-12-06 17:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-06 16:44 [PATCH] meson: sort C warning flags alphabetically Daniel P. Berrangé
2023-12-06 17:00 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f73fe5a4-dedc-4013-9b22-7bf25cdd37f1@linaro.org \
--to=philmd@linaro.org \
--cc=berrange@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).