From: Thomas Huth <thuth@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH for-7.2] tests/avocado/boot_linux.py: Bump aarch64 virt test timeout to 720s
Date: Thu, 17 Nov 2022 13:00:38 +0100 [thread overview]
Message-ID: <f7472193-f80c-49b7-f776-358cdea40b7a@redhat.com> (raw)
In-Reply-To: <20221117111628.911686-1-peter.maydell@linaro.org>
On 17/11/2022 12.16, Peter Maydell wrote:
> The two tests
> tests/avocado/boot_linux.py:BootLinuxAarch64.test_virt_tcg_gicv2
> tests/avocado/boot_linux.py:BootLinuxAarch64.test_virt_tcg_gicv3
>
> take quite a long time to run, and the current timeout of 240s
> is not enough for the tests to complete on slow machines:
> we've seen these tests time out in the gitlab CI in the
> 'avocado-system-alpine' CI job, for instance. The timeout
> is also insufficient for running the test with a debug build
> of QEMU: on my machine the tests take over 10 minutes to run
> in that config.
>
> Push the timeout up to 720s so that the test definitely has
> enough time to complete.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> tests/avocado/boot_linux.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/avocado/boot_linux.py b/tests/avocado/boot_linux.py
> index 571d33882ae..32adae6ff6a 100644
> --- a/tests/avocado/boot_linux.py
> +++ b/tests/avocado/boot_linux.py
> @@ -64,7 +64,7 @@ class BootLinuxAarch64(LinuxTest):
> :avocado: tags=machine:virt
> :avocado: tags=machine:gic-version=2
> """
> - timeout = 240
> + timeout = 720
Looking at some random older builds:
https://gitlab.com/qemu-project/qemu/-/jobs/2897087089#L175
https://gitlab.com/qemu-project/qemu/-/jobs/2897087091#L173
... it seems like the tests took 330 - 350 seconds to finish in the past in
the gitlab-CI, so the timeout of 720 seconds should be fine for the
gitlab-CI. Thus:
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2022-11-17 12:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-17 11:16 [PATCH for-7.2] tests/avocado/boot_linux.py: Bump aarch64 virt test timeout to 720s Peter Maydell
2022-11-17 12:00 ` Thomas Huth [this message]
2022-11-17 16:57 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7472193-f80c-49b7-f776-358cdea40b7a@redhat.com \
--to=thuth@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).