From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61DB8C3A59E for ; Wed, 21 Aug 2019 15:42:53 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 37E7E2339E for ; Wed, 21 Aug 2019 15:42:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 37E7E2339E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=vivier.eu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:49648 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i0Sl9-0000ca-Sm for qemu-devel@archiver.kernel.org; Wed, 21 Aug 2019 11:42:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50695) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i0SkH-00086n-Px for qemu-devel@nongnu.org; Wed, 21 Aug 2019 11:41:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i0SkG-00033S-DQ for qemu-devel@nongnu.org; Wed, 21 Aug 2019 11:41:57 -0400 Received: from mout.kundenserver.de ([212.227.126.135]:52965) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i0SkG-00031u-4Y for qemu-devel@nongnu.org; Wed, 21 Aug 2019 11:41:56 -0400 Received: from [192.168.100.1] ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue009 [213.165.67.103]) with ESMTPSA (Nemesis) id 1MEmAV-1i2vZI3xcp-00GGMx; Wed, 21 Aug 2019 17:41:48 +0200 To: Sandra Loosemore , qemu-devel@nongnu.org References: <20190821142151.19995-1-sandra@codesourcery.com> <20190821142151.19995-2-sandra@codesourcery.com> <608fde9c-bcac-9e6f-98f0-c208bda2eb5a@codesourcery.com> From: Laurent Vivier Openpgp: preference=signencrypt Autocrypt: addr=laurent@vivier.eu; prefer-encrypt=mutual; keydata= mQINBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABtCJMYXVyZW50IFZp dmllciA8bGF1cmVudEB2aXZpZXIuZXU+iQI4BBMBAgAiBQJWBTDeAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAAKCRDzDDi9Py++PCEdD/oD8LD5UWxhQrMQCsUgLlXCSM7sxGLkwmmF ozqSSljEGRhffxZvO35wMFcdX9Z0QOabVoFTKrT04YmvbjsErh/dP5zeM/4EhUByeOS7s6Yl HubMXVQTkak9Wa9Eq6irYC6L41QNzz/oTwNEqL1weV1+XC3TNnht9B76lIaELyrJvRfgsp9M rE+PzGPo5h7QHWdL/Cmu8yOtPLa8Y6l/ywEJ040IoiAUfzRoaJs2csMXf0eU6gVBhCJ4bs91 jtWTXhkzdl4tdV+NOwj3j0ukPy+RjqeL2Ej+bomnPTOW8nAZ32dapmu7Fj7VApuQO/BSIHyO NkowMMjB46yohEepJaJZkcgseaus0x960c4ua/SUm/Nm6vioRsxyUmWd2nG0m089pp8LPopq WfAk1l4GciiMepp1Cxn7cnn1kmG6fhzedXZ/8FzsKjvx/aVeZwoEmucA42uGJ3Vk9TiVdZes lqMITkHqDIpHjC79xzlWkXOsDbA2UY/P18AtgJEZQPXbcrRBtdSifCuXdDfHvI+3exIdTpvj BfbgZAar8x+lcsQBugvktlQWPfAXZu4Shobi3/mDYMEDOE92dnNRD2ChNXg2IuvAL4OW40wh gXlkHC1ZgToNGoYVvGcZFug1NI+vCeCFchX+L3bXyLMg3rAfWMFPAZLzn42plIDMsBs+x2yP +bkCDQRWBSYZARAAvFJBFuX9A6eayxUPFaEczlMbGXugs0mazbOYGlyaWsiyfyc3PStHLFPj rSTaeJpPCjBJErwpZUN4BbpkBpaJiMuVO6egrC8Xy8/cnJakHPR2JPEvmj7Gm/L9DphTcE15 92rxXLesWzGBbuYxKsj8LEnrrvLyi3kNW6B5LY3Id+ZmU8YTQ2zLuGV5tLiWKKxc6s3eMXNq wrJTCzdVd6ThXrmUfAHbcFXOycUyf9vD+s+WKpcZzCXwKgm7x1LKsJx3UhuzT8ier1L363RW ZaJBZ9CTPiu8R5NCSn9V+BnrP3wlFbtLqXp6imGhazT9nJF86b5BVKpF8Vl3F0/Y+UZ4gUwL d9cmDKBcmQU/JaRUSWvvolNu1IewZZu3rFSVgcpdaj7F/1aC0t5vLdx9KQRyEAKvEOtCmP4m 38kU/6r33t3JuTJnkigda4+Sfu5kYGsogeYG6dNyjX5wpK5GJIJikEhdkwcLM+BUOOTi+I9u tX03BGSZo7FW/J7S9y0l5a8nooDs2gBRGmUgYKqQJHCDQyYut+hmcr+BGpUn9/pp2FTWijrP inb/Pc96YDQLQA1q2AeAFv3Rx3XoBTGl0RCY4KZ02c0kX/dm3eKfMX40XMegzlXCrqtzUk+N 8LeipEsnOoAQcEONAWWo1HcgUIgCjhJhBEF0AcELOQzitbJGG5UAEQEAAYkCHwQYAQIACQUC VgUmGQIbDAAKCRDzDDi9Py++PCD3D/9VCtydWDdOyMTJvEMRQGbx0GacqpydMEWbE3kUW0ha US5jz5gyJZHKR3wuf1En/3z+CEAEfP1M3xNGjZvpaKZXrgWaVWfXtGLoWAVTfE231NMQKGoB w2Dzx5ivIqxikXB6AanBSVpRpoaHWb06tPNxDL6SVV9lZpUn03DSR6gZEZvyPheNWkvz7bE6 FcqszV/PNvwm0C5Ju7NlJA8PBAQjkIorGnvN/vonbVh5GsRbhYPOc/JVwNNr63P76rZL8Gk/ hb3xtcIEi5CCzab45+URG/lzc6OV2nTj9Lg0SNcRhFZ2ILE3txrmI+aXmAu26+EkxLLfqCVT ohb2SffQha5KgGlOSBXustQSGH0yzzZVZb+HZPEvx6d/HjQ+t9sO1bCpEgPdZjyMuuMp9N1H ctbwGdQM2Qb5zgXO+8ZSzwC+6rHHIdtcB8PH2j+Nd88dVGYlWFKZ36ELeZxD7iJflsE8E8yg OpKgu3nD0ahBDqANU/ZmNNarBJEwvM2vfusmNnWm3QMIwxNuJghRyuFfx694Im1js0ZY3LEU JGSHFG4ZynA+ZFUPA6Xf0wHeJOxGKCGIyeKORsteIqgnkINW9fnKJw2pgk8qHkwVc3Vu+wGS ZiJK0xFusPQehjWTHn9WjMG1zvQ5TQQHxau/2FkP45+nRPco6vVFQe8JmgtRF8WFJA== Message-ID: Date: Wed, 21 Aug 2019 17:41:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <608fde9c-bcac-9e6f-98f0-c208bda2eb5a@codesourcery.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:xzFUWbsae45w8PwjdF5vprnav7K3cQSxzXPrid5hmVYC2uHrQRy k9tXtis2YsYeIbTmMx9SxmJ7GLddHq+6tQ+GlgTwZTnNX5/7xnDxe5nF0pmBoRgeOwxZoFN SiVX83k9KJ19uV7wGj63asVmypnlqBCRq5XqN0huIY/05BYWgXHvRQBKGfB10pmmJdsMKSO OYdfzKK08mTT871HfwXtA== X-UI-Out-Filterresults: notjunk:1;V03:K0:DwkrF87Uq8g=:sPcJx6BFBbRK7yLUdoYBhJ leuJ4I7f77qj2cCE/epXuDIpfSZ0ijtCKDj3L15g8qJ+sElwkOkieRcw+u0U2qWpgDJhQfjQl xzd02PZwjDN0M0telcI43cHSZBpJZW0doAMjYunlaQDXL7kG/JkEXUYqGfT2GO4elWTzJuPNH qNxIhEmYVOerayOmhRdNHDptbXjwbLfTE8OErFNqycJpOwloSDMCYjl4JBdzvqCdiQTFefV0V C/cQcYsL8AKGx2Ar+yw2H7ARsW5VTnF0g/+pHTG2Zuzy7aA+hqeplExNoDhRaeWz6udXUGpuR mnLUMK04hmx1VOPNJI7+y0TKID9YtOp1tjyj5MyNz7qYbJlFxpKeD7xq0JIbczcUMmvCrdhSV vVfi2DklG3L4RvbA6dxZFEf4I70DI95KMckEjYceSB8QX1wTPmGLKygviNmydzh7YghK52ttE bHDOYZvEBbr6Ow5i7X2yIDMMhy0xsyrZnpGR9961yJ2XxhovKMgt6oLuMdLlg6jVtAFKKoWo3 6VGjk2bg1ZHCGkNDSjdXEFkgxpsReXbez7vfuMzIiAtnLXXL69pcgmU1YVpRLqJuDMkw6max8 H+HJCMZrD/W0HTgSsxBvN2BoVIdGILlNzqB4Xc7HZx6KVvJJLlll6qD3FMztQJZK/V16XSJ6c 7S7t3xrBNpQuzxIdOs68J7ysI9NyIrLgtAvJmj59K3Fx/MQPDTmcCTIRmQBLbaVgskCLvt7TK QqtG6OMCvmwb4Mt6uLTuyfwX2V1TQkKePQeumex/v3hicGxethX3BDAHexo= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.126.135 Subject: Re: [Qemu-devel] [PATCH 1/2] target/nios2: Fix bug in semihosted exit handling X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marek Vasut , Chris Wulff Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Le 21/08/2019 à 17:27, Sandra Loosemore a écrit : > On 8/21/19 8:41 AM, Laurent Vivier wrote: >> Le 21/08/2019 à 16:21, Sandra Loosemore a écrit : >>> This patch fixes a bug that caused semihosted exit to always return >>> status 0; it was incorrectly using the value of register R_ARG0 (which >>> contains the HOSTED_EXIT request number) instead of register R_ARG1. >>> >>> Signed-off-by: Sandra Loosemore >>> --- >>>   target/nios2/nios2-semi.c | 4 ++-- >>>   1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/target/nios2/nios2-semi.c b/target/nios2/nios2-semi.c >>> index d7a80dd..06c0861 100644 >>> --- a/target/nios2/nios2-semi.c >>> +++ b/target/nios2/nios2-semi.c >>> @@ -215,8 +215,8 @@ void do_nios2_semihosting(CPUNios2State *env) >>>       args = env->regs[R_ARG1]; >>>       switch (nr) { >>>       case HOSTED_EXIT: >>> -        gdb_exit(env, env->regs[R_ARG0]); >>> -        exit(env->regs[R_ARG0]); >>> +        gdb_exit(env, env->regs[R_ARG1]); >>> +        exit(env->regs[R_ARG1]); >> >> It's weird: in line 215,  env->regs[R_ARG1] is args. >> >> Are you sure it's not something like: >> >>          GET_ARG(0) >>          gdb_exit(env, arg0); >>          exit(arg0); >> >> same for m68k. >> >> Did you check the kernel code? > > It's not the kernel that's involved here, it's libgloss.  And yes, the > HOSTED_EXIT case takes an immediate argument in the register rather than > a pointer to an argument block. > > Here's the documentation for nios2 semihosting. > > https://www.sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;a=blob;f=libgloss/nios2/nios2-semi.txt;h=ded3a093c03dbae84cb95b4cd45bc3e0d751eda2;hb=HEAD > > > And m68k: > > https://www.sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;a=blob;f=libgloss/m68k/m68k-semi.txt;h=50520c15292aa7edf7eef28e09fd9202ce75b153;hb=HEAD > > > Again, a lot of cutting and pasting involved here.  ;-) > > -Sandra Thank you for the details. Could add this information in the commit messages of each patch? Reviewed-by: Laurent Vivier