From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54157) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gPtkk-0006vR-9i for qemu-devel@nongnu.org; Thu, 22 Nov 2018 13:31:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gPtkj-0005r4-LR for qemu-devel@nongnu.org; Thu, 22 Nov 2018 13:31:02 -0500 References: <20181021190721.2148-1-hpoussin@reactos.org> <0b492470-2146-c75a-6be6-0a2c5d0ebf5c@reactos.org> From: =?UTF-8?Q?Herv=c3=a9_Poussineau?= Message-ID: Date: Thu, 22 Nov 2018 19:30:41 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH-for-3.1] [REGRESSION FIX] ps2kbd: default to scan enabled after reset List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Herv=c3=a9_Poussineau?= , qemu-devel@nongnu.org, Paolo Bonzini , "Michael S. Tsirkin" Cc: Geoffrey McRae , qemu-ppc@nongnu.org, Gerd Hoffmann Ping again. Le 18/11/2018 à 11:09, Hervé Poussineau a écrit : > Ping again. > > v3.0 didn't contain 143c04c7e0639e53086519592ead15d2556bfbf2, so this commit fixes a regression. > > Le 10/11/2018 à 21:53, Hervé Poussineau a écrit : >> Ping. >> >> Le 21/10/2018 à 21:07, Hervé Poussineau a écrit : >>> A check for scan_enabled has been added to ps2_keyboard_event in commit >>> 143c04c7e0639e53086519592ead15d2556bfbf2 to prevent stream corruption. >>> This works well as long as operating system is resetting keyboard, or enabling it. >>> >>> This fixes IBM 40p firmware, which doesn't bother sending KBD_CMD_RESET, >>> KBD_CMD_ENABLE or KBD_CMD_RESET_ENABLE before trying to use the keyboard. >>> >>> Signed-off-by: Hervé Poussineau >>> --- >>>   hw/input/ps2.c | 2 +- >>>   1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/hw/input/ps2.c b/hw/input/ps2.c >>> index fdfcadf9a1..eded4f0f8d 100644 >>> --- a/hw/input/ps2.c >>> +++ b/hw/input/ps2.c >>> @@ -938,7 +938,7 @@ static void ps2_kbd_reset(void *opaque) >>>       trace_ps2_kbd_reset(opaque); >>>       ps2_common_reset(&s->common); >>> -    s->scan_enabled = 0; >>> +    s->scan_enabled = 1; >>>       s->translate = 0; >>>       s->scancode_set = 2; >>>       s->modifiers = 0; >>> >> > >