From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42379) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ecajJ-000458-Nt for qemu-devel@nongnu.org; Fri, 19 Jan 2018 12:45:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ecajG-0001vb-I4 for qemu-devel@nongnu.org; Fri, 19 Jan 2018 12:45:29 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:45128) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ecajG-0001vQ-97 for qemu-devel@nongnu.org; Fri, 19 Jan 2018 12:45:26 -0500 Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w0JHhRQL127866 for ; Fri, 19 Jan 2018 12:45:25 -0500 Received: from e06smtp11.uk.ibm.com (e06smtp11.uk.ibm.com [195.75.94.107]) by mx0a-001b2d01.pphosted.com with ESMTP id 2fkkj04fe6-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Fri, 19 Jan 2018 12:45:24 -0500 Received: from localhost by e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 19 Jan 2018 17:45:22 -0000 From: Christian Borntraeger References: <1516380179-12737-1-git-send-email-borntraeger@de.ibm.com> <10f37bd8-eecd-bd12-820a-e485397cb496@de.ibm.com> Date: Fri, 19 Jan 2018 18:45:13 +0100 MIME-Version: 1.0 In-Reply-To: <10f37bd8-eecd-bd12-820a-e485397cb496@de.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Message-Id: Subject: Re: [Qemu-devel] [qemu-s390x] [PATCH 12/12] Fix configure for s390 qemu on alpine List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-s390x@nongnu.org, qemu-devel@nongnu.org, Peter Maydell , Paolo Bonzini Cc: Alice Frosi And the from email address is also wrong. (spurious x after .com) On 01/19/2018 05:53 PM, Christian Borntraeger wrote: > ignore the 12/12, it is just one patch.... > > On 01/19/2018 05:42 PM, Christian Borntraeger wrote: >> From: Alice Frosi >> >> In alpine docker image the qemu-system-s390x build is broken and >> it throws this error: >> qemu-system-s390x: Initialization of device s390-ipl failed: could not >> load bootloader 's390-ccw.img' >> >> The grep command of busybox uses regex. This fails on binary data >> (e.g. stops on every \0), so it does not identify the string >> BiGeNdIaN in the test case big/little. Therefore, it assumes >> that the architecture is little endian. >> >> This fix solves the grep problem by printing the content of >> TMPO with strings >> >> Signed-off-by: Alice Frosi >> Signed-off-by: Christian Borntraeger >> [some changes to patch description, add -a option to strings] >> --- >> configure | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/configure b/configure >> index 6d8c996..383b14e 100755 >> --- a/configure >> +++ b/configure >> @@ -1906,9 +1906,9 @@ int main(int argc, char *argv[]) { >> EOF >> >> if compile_object ; then >> - if grep -q BiGeNdIaN $TMPO ; then >> + if strings -a $TMPO | grep -q BiGeNdIaN ; then >> bigendian="yes" >> - elif grep -q LiTtLeEnDiAn $TMPO ; then >> + elif strings -a $TMPO | grep -q LiTtLeEnDiAn ; then >> bigendian="no" >> else >> echo big/little test failed >> > >