QEMU-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Rosato <mjrosato@linux.ibm.com>
To: zhaoguohan@kylinos.cn, qemu-devel@nongnu.org
Cc: qemu-s390x@nongnu.org, "Alex Williamson" <alex@shazbot.org>,
	"Cédric Le Goater" <clg@redhat.com>,
	"Cornelia Huck" <cohuck@redhat.com>,
	"Eric Farman" <farman@linux.ibm.com>,
	"Tony Krowiak" <akrowiak@linux.ibm.com>,
	"Halil Pasic" <pasic@linux.ibm.com>,
	"Jason Herne" <jjherne@linux.ibm.com>
Subject: Re: [PATCH v2 0/2] vfio: propagate IRQ notifier registration failure
Date: Mon, 11 May 2026 10:15:43 -0400	[thread overview]
Message-ID: <f776d88f-e5a5-4e14-846c-c313cb8ab9a4@linux.ibm.com> (raw)
In-Reply-To: <20260510084353.58263-1-zhaoguohan@kylinos.cn>

On 5/10/26 4:43 AM, zhaoguohan@kylinos.cn wrote:
> From: GuoHan Zhao <zhaoguohan@kylinos.cn>
> 
> vfio_ap_register_irq_notifier() and vfio_ccw_register_irq_notifier() clean
> up the fd handler and EventNotifier when vfio_device_irq_set_signaling()
> fails, but still return true to their callers.
> 
> Return false after cleanup so callers can handle the failed registration
> path instead of treating it as a successful notifier setup.
> 
> Please ignore the previous version.
> 
> GuoHan Zhao (2):
>   vfio/ap: Return false when IRQ notifier setup fails
>   vfio/ccw: Return false when IRQ notifier setup fails
> 
>  hw/vfio/ap.c  | 1 +
>  hw/vfio/ccw.c | 1 +
>  2 files changed, 2 insertions(+)
> 

For the series:

Reviewed-by: Matthew Rosato <mjrosato@linux.ibm.com>


      parent reply	other threads:[~2026-05-11 14:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-10  8:43 [PATCH v2 0/2] vfio: propagate IRQ notifier registration failure zhaoguohan
2026-05-10  8:43 ` [PATCH v2 1/2] vfio/ap: Return false when IRQ notifier setup fails zhaoguohan
2026-05-11 10:30   ` Anthony Krowiak
2026-05-10  8:43 ` [PATCH v2 2/2] vfio/ccw: " zhaoguohan
2026-05-11 13:00   ` Eric Farman
2026-05-10 16:09 ` [PATCH v2 0/2] vfio: propagate IRQ notifier registration failure Cédric Le Goater
2026-05-11 14:15 ` Matthew Rosato [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f776d88f-e5a5-4e14-846c-c313cb8ab9a4@linux.ibm.com \
    --to=mjrosato@linux.ibm.com \
    --cc=akrowiak@linux.ibm.com \
    --cc=alex@shazbot.org \
    --cc=clg@redhat.com \
    --cc=cohuck@redhat.com \
    --cc=farman@linux.ibm.com \
    --cc=jjherne@linux.ibm.com \
    --cc=pasic@linux.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=zhaoguohan@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox