From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 769FDC5519F for ; Sat, 21 Nov 2020 19:54:19 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CBB4B221FB for ; Sat, 21 Nov 2020 19:54:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="RQ1Gex6a" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CBB4B221FB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:42658 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kgYxd-0005Md-Od for qemu-devel@archiver.kernel.org; Sat, 21 Nov 2020 14:54:17 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:36916) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kgYvL-00041o-NZ for qemu-devel@nongnu.org; Sat, 21 Nov 2020 14:51:56 -0500 Received: from mail-pg1-x543.google.com ([2607:f8b0:4864:20::543]:33608) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kgYvF-0007Ck-L3 for qemu-devel@nongnu.org; Sat, 21 Nov 2020 14:51:55 -0500 Received: by mail-pg1-x543.google.com with SMTP id 81so10479925pgf.0 for ; Sat, 21 Nov 2020 11:51:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=8bH88tanQCDXMNbvU3ojA+WtU0qAJnx5/BAatZe0a1k=; b=RQ1Gex6aiReL0g9gcP2hmk5FOBb0Fr13OjIlfFRpZdhStRTOaqFwN0NvT6gXBpJuLH Oig3lApItFD6SKfqC5Kb5l7AggLx7tZhbNZg65FSbY9ia/gLnwexo457jxR8EJV45KaM EWL+rjkxs8QajGkA7tk8J6FVqpybbFZ89mZ2qJFNVZ/9MgW4Om74Zu0vu73YNviVQSNY RjBTETaU8v0NrZ0cKudofu2qXgfs4eY1Moa/OqwToZ4KEOXru6WUfPiNBhPlO5YjazsU j1gthve7G9GKWyqil90ghoos27UG11aJ3w3Uz73LW8YguypMv9uXigXvi3eOqYaaBXKS YSXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=8bH88tanQCDXMNbvU3ojA+WtU0qAJnx5/BAatZe0a1k=; b=p60hnTeEs1W03pGkrX+MEn1Q9AX/vVml80RecHE7J0Mjh8jzYmICwsFXIiEXvMyfpY smj8LA6pxxWB+1gydfqohubXRB85XpM5JSHdrWWGGvP7/AEPcGhb4dMEziAOGt202ec/ ZutvoJkNfp6jeBtUoIaIp5gQtnrNJHlq3WlpHFuV+jkCMWG8BEGQplMZv97+Nn+NLk5u MY1PrAWq1V839XVKwXlZRzzuqovWRNzrItaczK9Iji5isvopR9RxnhzQNwUsE9OlidV/ /fAH7FP4osrQklHYYdPtdUODORMnql7U3qc9fuhpO+jZyxWzv7GMAXbWg5uVkA88FYi9 ir/w== X-Gm-Message-State: AOAM533vCSVggJ4TErILlC8RZ7fuR75ivLoKgY/cHRuznX/R4xHl3vtz gNEvD8YWLiZDO0B6dTozJSuSmg== X-Google-Smtp-Source: ABdhPJwl1E8IyGwPzPYAQnxOwcRsAmgWLJ25VMnETzDjHZIXM0f7jz7ec1My7ce4IM9XcpoPSOan6w== X-Received: by 2002:a17:90b:50e:: with SMTP id r14mr16795014pjz.193.1605988307465; Sat, 21 Nov 2020 11:51:47 -0800 (PST) Received: from [192.168.1.11] ([71.212.141.89]) by smtp.gmail.com with ESMTPSA id 92sm8977241pjv.32.2020.11.21.11.51.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 21 Nov 2020 11:51:46 -0800 (PST) Subject: Re: [PATCH 07/26] target/mips: Extract DSP translation routines To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org References: <20201120210844.2625602-1-f4bug@amsat.org> <20201120210844.2625602-8-f4bug@amsat.org> From: Richard Henderson Message-ID: Date: Sat, 21 Nov 2020 11:51:44 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201120210844.2625602-8-f4bug@amsat.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::543; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x543.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fredrik Noring , Craig Janeczek , Aleksandar Rikalo , Laurent Vivier , Paolo Bonzini , Huacai Chen , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 11/20/20 1:08 PM, Philippe Mathieu-Daudé wrote: > Extract 2150 lines from the huge translate.c to a new file, > 'mod-mips-dsp_translate.c.inc'. As there are too many inter- > dependencies we don't compile it as another object, but > keep including it in the big translate.o. We gain in code > maintainability. > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/mips/mod-mips-dsp_helper.c | 2 + > target/mips/translate.c | 2150 +-------------------- > target/mips/mod-mips-dsp_translate.c.inc | 2158 ++++++++++++++++++++++ > 3 files changed, 2164 insertions(+), 2146 deletions(-) > create mode 100644 target/mips/mod-mips-dsp_translate.c.inc Reviewed-by: Richard Henderson > +++ b/target/mips/mod-mips-dsp_helper.c > @@ -15,6 +15,8 @@ > * > * You should have received a copy of the GNU Lesser General Public > * License along with this library; if not, see . > + * > + * SPDX-License-Identifier: LGPL-2.1-or-later Needs to get folded back to patch 5. r~