From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: "Cédric Le Goater" <clg@redhat.com>,
qemu-ppc@nongnu.org, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Nicholas Piggin <npiggin@gmail.com>,
Daniel Henrique Barboza <danielhb413@gmail.com>,
Harsh Prateek Bora <harshpb@linux.ibm.com>,
David Gibson <david@gibson.dropbear.id.au>,
Zhenzhong Duan <zhenzhong.duan@intel.com>
Subject: Re: [PATCH] hw/ppc/Kconfig: Imply VFIO_PCI
Date: Fri, 24 Nov 2023 11:10:08 +0100 [thread overview]
Message-ID: <f77896fc-18b5-4f85-b621-89b84dc26b63@linaro.org> (raw)
In-Reply-To: <20231124080658.893770-1-clg@redhat.com>
On 24/11/23 09:06, Cédric Le Goater wrote:
> When the legacy and iommufd backends were introduced, a set of common
> vfio-pci routines were exported in pci.c for both backends to use :
>
> vfio_pci_pre_reset
> vfio_pci_get_pci_hot_reset_info
> vfio_pci_host_match
> vfio_pci_post_reset
>
> This introduced a build failure on PPC when --without-default-devices
> is use because VFIO is always selected in ppc/Kconfig but VFIO_PCI is
> not.
>
> Use an 'imply VFIO_PCI' in ppc/Kconfig and bypass compilation of the
> VFIO EEH hooks routines defined in hw/ppc/spapr_pci_vfio.c with
> CONFIG_VFIO_PCI.
>
> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
> Signed-off-by: Cédric Le Goater <clg@redhat.com>
> ---
> hw/ppc/spapr_pci_vfio.c | 36 ++++++++++++++++++++++++++++++++++++
> hw/ppc/Kconfig | 2 +-
> 2 files changed, 37 insertions(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Thanks for reworking it without adding more stubs :)
next prev parent reply other threads:[~2023-11-24 10:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-24 8:06 [PATCH] hw/ppc/Kconfig: Imply VFIO_PCI Cédric Le Goater
2023-11-24 10:10 ` Philippe Mathieu-Daudé [this message]
2023-11-24 12:32 ` Cédric Le Goater
2023-11-28 17:11 ` Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f77896fc-18b5-4f85-b621-89b84dc26b63@linaro.org \
--to=philmd@linaro.org \
--cc=clg@redhat.com \
--cc=danielhb413@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=harshpb@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=zhenzhong.duan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).