[PATCH] scripts/device-crash-test: fix spurious EOFError messages

[PATCH] scripts/device-crash-test: fix spurious EOFError messages

[John Snow]

When the QMP library was updated to match the standalone repository in
094ded52, I neglected to update the logging filter(s) in
device-crash-test, which allowed the spurious messages to leak through.

Update the log filter to re-suppress these messages.

Fixes: 094ded52
Reported-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: John Snow <jsnow@redhat.com>
---
 scripts/device-crash-test | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/device-crash-test b/scripts/device-crash-test
index 1ecb9663ae8..c1576e8b966 100755
--- a/scripts/device-crash-test
+++ b/scripts/device-crash-test
@@ -527,7 +527,7 @@ def main():
         # Async QMP, when in use, is chatty about connection failures.
         # This script knowingly generates a ton of connection errors.
         # Silence this logger.
-        logging.getLogger('qemu.qmp.qmp_client').setLevel(logging.CRITICAL)
+        logging.getLogger('qemu.qmp.protocol').setLevel(logging.CRITICAL)
 
     fatal_failures = []
     wl_stats = {}
-- 
2.51.0

Re: [PATCH] scripts/device-crash-test: fix spurious EOFError messages

[Thomas Huth]

On 22/10/2025 23.31, John Snow wrote:
> When the QMP library was updated to match the standalone repository in
> 094ded52, I neglected to update the logging filter(s) in
> device-crash-test, which allowed the spurious messages to leak through.
> 
> Update the log filter to re-suppress these messages.
> 
> Fixes: 094ded52
> Reported-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>   scripts/device-crash-test | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/device-crash-test b/scripts/device-crash-test
> index 1ecb9663ae8..c1576e8b966 100755
> --- a/scripts/device-crash-test
> +++ b/scripts/device-crash-test
> @@ -527,7 +527,7 @@ def main():
>           # Async QMP, when in use, is chatty about connection failures.
>           # This script knowingly generates a ton of connection errors.
>           # Silence this logger.
> -        logging.getLogger('qemu.qmp.qmp_client').setLevel(logging.CRITICAL)
> +        logging.getLogger('qemu.qmp.protocol').setLevel(logging.CRITICAL)
>   
>       fatal_failures = []
>       wl_stats = {}

Thanks, that silences the messages, indeed!

Tested-by: Thomas Huth <thuth@redhat.com>

Re: [PATCH] scripts/device-crash-test: fix spurious EOFError messages

[John Snow]

On Thu, Oct 23, 2025 at 3:01 AM Thomas Huth <thuth@redhat.com> wrote:
>
> On 22/10/2025 23.31, John Snow wrote:
> > When the QMP library was updated to match the standalone repository in
> > 094ded52, I neglected to update the logging filter(s) in
> > device-crash-test, which allowed the spurious messages to leak through.
> >
> > Update the log filter to re-suppress these messages.
> >
> > Fixes: 094ded52
> > Reported-by: Thomas Huth <thuth@redhat.com>
> > Signed-off-by: John Snow <jsnow@redhat.com>
> > ---
> >   scripts/device-crash-test | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/scripts/device-crash-test b/scripts/device-crash-test
> > index 1ecb9663ae8..c1576e8b966 100755
> > --- a/scripts/device-crash-test
> > +++ b/scripts/device-crash-test
> > @@ -527,7 +527,7 @@ def main():
> >           # Async QMP, when in use, is chatty about connection failures.
> >           # This script knowingly generates a ton of connection errors.
> >           # Silence this logger.
> > -        logging.getLogger('qemu.qmp.qmp_client').setLevel(logging.CRITICAL)
> > +        logging.getLogger('qemu.qmp.protocol').setLevel(logging.CRITICAL)
> >
> >       fatal_failures = []
> >       wl_stats = {}
>
> Thanks, that silences the messages, indeed!
>
> Tested-by: Thomas Huth <thuth@redhat.com>

The library is designed to be very vocal about connection failures so
that tests don't silently fail even when there's no output expected,
but for a test where we're intentionally trying to see if QEMU crashes
over and over, it's not really so helpful :)

thanks for the report!