From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48822) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bzVYU-0002kU-9i for qemu-devel@nongnu.org; Wed, 26 Oct 2016 17:16:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bzVYR-00055Q-0v for qemu-devel@nongnu.org; Wed, 26 Oct 2016 17:16:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36474) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1bzVYQ-000558-P3 for qemu-devel@nongnu.org; Wed, 26 Oct 2016 17:16:10 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0AB647AE97 for ; Wed, 26 Oct 2016 21:16:10 +0000 (UTC) References: <1477078935-7182-1-git-send-email-quintela@redhat.com> <1477078935-7182-5-git-send-email-quintela@redhat.com> From: Eric Blake Message-ID: Date: Wed, 26 Oct 2016 16:16:08 -0500 MIME-Version: 1.0 In-Reply-To: <1477078935-7182-5-git-send-email-quintela@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="h5B5VbEiHXjg2WF0qtm2FtGckDOjFKb0L" Subject: Re: [Qemu-devel] [PATCH 04/13] migration: Create x-multifd-threads parameter List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela , qemu-devel@nongnu.org Cc: amit.shah@redhat.com, dgilbert@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --h5B5VbEiHXjg2WF0qtm2FtGckDOjFKb0L From: Eric Blake To: Juan Quintela , qemu-devel@nongnu.org Cc: amit.shah@redhat.com, dgilbert@redhat.com Message-ID: Subject: Re: [Qemu-devel] [PATCH 04/13] migration: Create x-multifd-threads parameter References: <1477078935-7182-1-git-send-email-quintela@redhat.com> <1477078935-7182-5-git-send-email-quintela@redhat.com> In-Reply-To: <1477078935-7182-5-git-send-email-quintela@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/21/2016 02:42 PM, Juan Quintela wrote: > Indicates the number of threads that we would create. By default we > create 2 threads. >=20 > Signed-off-by: Juan Quintela > --- > @@ -1386,6 +1389,9 @@ void hmp_migrate_set_parameter(Monitor *mon, cons= t QDict *qdict) > p.has_downtime_limit =3D true; > use_int_value =3D true; > break; > + case MIGRATION_PARAMETER_X_MULTIFD_THREADS: > + p.has_x_multifd_threads =3D true; > + break; Won't work unless you add a line 'use_int_value =3D true;' > } >=20 > if (use_int_value) { > @@ -1402,6 +1408,7 @@ void hmp_migrate_set_parameter(Monitor *mon, cons= t QDict *qdict) > p.cpu_throttle_initial =3D valueint; > p.cpu_throttle_increment =3D valueint; > p.downtime_limit =3D valueint; > + p.x_multifd_threads =3D valueint; > } See also commit bb2b777 as a regression fix for a missing use_int_value. > +++ b/qapi-schema.json > @@ -665,13 +665,16 @@ > # @downtime-limit: set maximum tolerated downtime for migration. maxim= um > # downtime in milliseconds (Since 2.8) > # > +# @x-multifd-threads: Number of threads used to migrate data in parall= el > +# The default value is 1 (since 2.8) > +# > # Since: 2.4 > ## > { 'enum': 'MigrationParameter', > 'data': ['compress-level', 'compress-threads', 'decompress-threads',= > 'cpu-throttle-initial', 'cpu-throttle-increment', > 'tls-creds', 'tls-hostname', 'max-bandwidth', > - 'downtime-limit'] } > + 'downtime-limit', 'x-multifd-threads'] } >=20 > # > # @migrate-set-parameters > @@ -726,6 +729,9 @@ > # @downtime-limit: set maximum tolerated downtime for migration. maxim= um > # downtime in milliseconds (Since 2.8) > # > +# @x-multifd-threads: Number of threads used to migrate data in parall= el > +# The default value is 1 (since 2.8) Pre-existing in the other parameters, but we have an inconsistent use of #optional markers here. > +# > # Since: 2.4 > ## > { 'struct': 'MigrationParameters', > @@ -737,7 +743,8 @@ > '*tls-creds': 'str', > '*tls-hostname': 'str', > '*max-bandwidth': 'int', > - '*downtime-limit': 'int'} } > + '*downtime-limit': 'int', > + '*x-multifd-threads': 'int'} } > ## > # @query-migrate-parameters > # >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --h5B5VbEiHXjg2WF0qtm2FtGckDOjFKb0L Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJYER0YAAoJEKeha0olJ0NqD6UH/2px5rICdonT5JJHA1+Js3Yl Wp7yTfTt0lEThCOt5egXWfHP+o5JWPG7ELI9EUE82Wa65APZCQOCBh98Zlr2zMhF Jn9ZFyXlv42/ixZSCUMhSQoyIoG6hwo/oehsW4MxDhTOk/zLMzAvxMQcIs4Vzkdq +mkPV/KYhGTufVtuCgLrVSJmJrczdtkLiZ2HtfI8zQomHvrVbzLxTYri6bttsGyv PTqYon4ajoKbmEid+MZOSCUZtFXhrOii7zHVMNyPuEtHhIcRm0dHTYKZLWUd4Vlb 4s0Gk74YdlLgqnXeeMDEsJ9pjLt2eEe6Xsl+6IKrWKiPIx2XunmEjQRjIbzAVjU= =xtG5 -----END PGP SIGNATURE----- --h5B5VbEiHXjg2WF0qtm2FtGckDOjFKb0L--