From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Cc: Aurelien Jarno <aurelien@aurel32.net>,
Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>,
Craig Janeczek <jancraig@amazon.com>
Subject: Re: [PATCH v4 09/12] target/mips: Convert decode_opc_mxu() to decodetree prototype
Date: Wed, 24 Feb 2021 11:06:51 -0800 [thread overview]
Message-ID: <f78ee50d-1837-6b92-3aa8-9eab534076a8@linaro.org> (raw)
In-Reply-To: <20210224185706.3293058-10-f4bug@amsat.org>
On 2/24/21 10:57 AM, Philippe Mathieu-Daudé wrote:
> To easily convert MXU code to decodetree, making it return a boolean.
>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> target/mips/translate.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
You'll want to mention the function rename, which is new in this revision iirc.
r~
next prev parent reply other threads:[~2021-02-24 19:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-24 18:56 [PATCH v4 00/12] target/mips: Extract MXU code to new mxu_translate.c file Philippe Mathieu-Daudé
2021-02-24 18:56 ` [PATCH v4 01/12] target/mips/meson: Introduce mips_tcg source set Philippe Mathieu-Daudé
2021-02-24 19:05 ` Richard Henderson
2021-02-24 18:56 ` [PATCH v4 02/12] target/mips/meson: Restrict mips-semi.c to TCG Philippe Mathieu-Daudé
2021-02-24 19:05 ` Richard Henderson
2021-02-24 18:56 ` [PATCH v4 03/12] target/mips: Rewrite complex ifdef'ry Philippe Mathieu-Daudé
2021-02-24 18:56 ` [PATCH v4 04/12] target/mips: Remove XBurst Media eXtension Unit dead code Philippe Mathieu-Daudé
2021-02-24 18:56 ` [PATCH v4 05/12] target/mips: Remove unused CPUMIPSState* from MXU functions Philippe Mathieu-Daudé
2021-02-24 18:57 ` [PATCH v4 06/12] target/mips: Pass instruction opcode to decode_opc_mxu() Philippe Mathieu-Daudé
2021-02-24 18:57 ` [PATCH v4 07/12] target/mips: Use OPC_MUL instead of OPC__MXU_MUL Philippe Mathieu-Daudé
2021-02-24 18:57 ` [PATCH v4 08/12] target/mips: Move MUL opcode check from decode_mxu() to decode_legacy() Philippe Mathieu-Daudé
2021-02-24 19:06 ` Richard Henderson
2021-02-24 18:57 ` [PATCH v4 09/12] target/mips: Convert decode_opc_mxu() to decodetree prototype Philippe Mathieu-Daudé
2021-02-24 19:06 ` Richard Henderson [this message]
2021-02-24 18:57 ` [PATCH v4 10/12] target/mips: Simplify decode_opc_mxu() ifdef'ry Philippe Mathieu-Daudé
2021-02-24 19:07 ` Richard Henderson
2021-02-24 18:57 ` [PATCH v4 11/12] target/mips: Introduce mxu_translate_init() helper Philippe Mathieu-Daudé
2021-02-24 18:57 ` [PATCH v4 12/12] target/mips: Extract MXU code to new mxu_translate.c file Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f78ee50d-1837-6b92-3aa8-9eab534076a8@linaro.org \
--to=richard.henderson@linaro.org \
--cc=aleksandar.rikalo@syrmia.com \
--cc=aurelien@aurel32.net \
--cc=f4bug@amsat.org \
--cc=jancraig@amazon.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).