qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Osipenko <dmitry.osipenko@collabora.com>
To: "Akihiko Odaki" <akihiko.odaki@daynix.com>,
	"Huang Rui" <ray.huang@amd.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Michael S . Tsirkin" <mst@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>
Cc: "Gert Wollny" <gert.wollny@collabora.com>,
	qemu-devel@nongnu.org,
	"Gurchetan Singh" <gurchetansingh@chromium.org>,
	"Alyssa Ross" <hi@alyssa.is>,
	"Roger Pau Monné" <roger.pau@citrix.com>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Stefano Stabellini" <stefano.stabellini@amd.com>,
	"Christian König" <christian.koenig@amd.com>,
	"Xenia Ragiadakou" <xenia.ragiadakou@amd.com>,
	"Pierre-Eric Pelloux-Prayer" <pierre-eric.pelloux-prayer@amd.com>,
	"Honglei Huang" <honglei1.huang@amd.com>,
	"Julia Zhang" <julia.zhang@amd.com>,
	"Chen Jiqian" <Jiqian.Chen@amd.com>,
	"Rob Clark" <robdclark@gmail.com>,
	"Yiwei Zhang" <zzyiwei@chromium.org>,
	"Sergio Lopez Pascual" <slp@redhat.com>
Subject: Re: [PATCH v2 5/6] virtio-gpu: Support asynchronous fencing
Date: Sat, 19 Oct 2024 00:31:27 +0300	[thread overview]
Message-ID: <f79ebab7-fe1c-419d-89d5-6238b0b36ba5@collabora.com> (raw)
In-Reply-To: <9362f8ac-5616-4f6d-b424-3a2b679c2141@daynix.com>

On 10/18/24 08:28, Akihiko Odaki wrote:
>> +static void virgl_write_context_fence(void *opaque, uint32_t ctx_id,
>> +                                      uint32_t ring_idx, uint64_t fence)
>> +{
>> +    VirtIOGPU *g = opaque;
> 
> What about taking the BQL here instead of having a QEMUBH?

That will block virglrenderer thread writing the fence, which in turns
might block other virglrenderer threads.

-- 
Best regards,
Dmitry


  reply	other threads:[~2024-10-18 21:32 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-15  4:32 [PATCH v2 0/6] Support virtio-gpu DRM native context Dmitry Osipenko
2024-10-15  4:32 ` [PATCH v2 1/6] ui/sdl2: Restore original context after new context creation Dmitry Osipenko
2024-10-15  4:32 ` [PATCH v2 2/6] ui/sdl2: Implement dpy dmabuf functions Dmitry Osipenko
2024-10-18  5:22   ` Akihiko Odaki
2024-10-21  1:02     ` Dmitry Osipenko
2024-10-15  4:32 ` [PATCH v2 3/6] linux-headers: Update to Linux v6.12-rc1 Dmitry Osipenko
2024-10-15  4:32 ` [PATCH v2 4/6] virtio-gpu: Handle virgl fence creation errors Dmitry Osipenko
2024-10-15  4:32 ` [PATCH v2 5/6] virtio-gpu: Support asynchronous fencing Dmitry Osipenko
2024-10-18  5:28   ` Akihiko Odaki
2024-10-18 21:31     ` Dmitry Osipenko [this message]
2024-10-22  5:11       ` Akihiko Odaki
2024-10-22 12:37         ` Dmitry Osipenko
2024-10-22 12:44           ` Dmitry Osipenko
2024-10-23  7:51             ` Akihiko Odaki
2024-10-23 10:04   ` Akihiko Odaki
2024-10-24  0:09     ` Dmitry Osipenko
2024-10-15  4:32 ` [PATCH v2 6/6] virtio-gpu: Support DRM native context Dmitry Osipenko
2024-10-18  5:33   ` Akihiko Odaki
2024-10-21  1:33     ` Dmitry Osipenko
2024-10-24 10:09 ` [PATCH v2 0/6] Support virtio-gpu " Alex Bennée
2024-10-24 12:21   ` Dmitry Osipenko
2024-10-24 12:45     ` Alex Bennée
2024-10-24 17:12       ` Dmitry Osipenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f79ebab7-fe1c-419d-89d5-6238b0b36ba5@collabora.com \
    --to=dmitry.osipenko@collabora.com \
    --cc=Jiqian.Chen@amd.com \
    --cc=akihiko.odaki@daynix.com \
    --cc=alex.bennee@linaro.org \
    --cc=alexander.deucher@amd.com \
    --cc=christian.koenig@amd.com \
    --cc=gert.wollny@collabora.com \
    --cc=gurchetansingh@chromium.org \
    --cc=hi@alyssa.is \
    --cc=honglei1.huang@amd.com \
    --cc=julia.zhang@amd.com \
    --cc=kraxel@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@linaro.org \
    --cc=pierre-eric.pelloux-prayer@amd.com \
    --cc=qemu-devel@nongnu.org \
    --cc=ray.huang@amd.com \
    --cc=robdclark@gmail.com \
    --cc=roger.pau@citrix.com \
    --cc=slp@redhat.com \
    --cc=stefano.stabellini@amd.com \
    --cc=xenia.ragiadakou@amd.com \
    --cc=zzyiwei@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).