qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Amit Shah <amit.shah@redhat.com>
To: qemu list <qemu-devel@nongnu.org>
Cc: Amit Shah <amit.shah@redhat.com>,
	Gerd Hoffmann <kraxel@redhat.com>,
	Markus Armbruster <armbru@redhat.com>,
	Luiz Capitulino <lcapitulino@redhat.com>
Subject: [Qemu-devel] [PATCH 1/2] qdev: Allow hot-plug for lists with pre-filled descriptors
Date: Thu, 10 Feb 2011 15:46:11 +0530	[thread overview]
Message-ID: <f7b414baf43f7e25050a9388e16e807dae7bf8a3.1297332970.git.amit.shah@redhat.com> (raw)

This will be needed for hot-plugging chardevs.

Signed-off-by: Amit Shah <amit.shah@redhat.com>
---
 monitor.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/monitor.c b/monitor.c
index 7fc311d..f3d7ab3 100644
--- a/monitor.c
+++ b/monitor.c
@@ -74,8 +74,6 @@
  * 'O'          option string of the form NAME=VALUE,...
  *              parsed according to QemuOptsList given by its name
  *              Example: 'device:O' uses qemu_device_opts.
- *              Restriction: only lists with empty desc are supported
- *              TODO lift the restriction
  * 'i'          32 bit integer
  * 'l'          target long (32 or 64 bit)
  * 'M'          just like 'l', except in user mode the value is
@@ -4064,7 +4062,7 @@ static const mon_cmd_t *monitor_parse_command(Monitor *mon,
                 QemuOpts *opts;
 
                 opts_list = qemu_find_opts(key);
-                if (!opts_list || opts_list->desc->name) {
+                if (!opts_list) {
                     goto bad_type;
                 }
                 while (qemu_isspace(*p)) {
-- 
1.7.4

             reply	other threads:[~2011-02-10 10:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-10 10:16 Amit Shah [this message]
2011-02-10 10:16 ` [Qemu-devel] [PATCH 2/2] qdev: Allow chardevs to be hot-plugged Amit Shah
2011-02-10 11:57 ` [Qemu-devel] [PATCH 1/2] qdev: Allow hot-plug for lists with pre-filled descriptors Markus Armbruster
2011-02-10 12:08   ` Amit Shah

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f7b414baf43f7e25050a9388e16e807dae7bf8a3.1297332970.git.amit.shah@redhat.com \
    --to=amit.shah@redhat.com \
    --cc=armbru@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).