From: Paolo Bonzini <pbonzini@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
"Daniel P. Berrange" <berrange@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>,
qemu-devel@nongnu.org, Roman Bolshakov <r.bolshakov@yadro.com>,
John Snow <jsnow@redhat.com>
Subject: Re: [PATCH for-6.0 1/6] qapi: Add query-accel command
Date: Wed, 18 Nov 2020 15:54:00 +0100 [thread overview]
Message-ID: <f7b4c4d2-3cb6-37a9-45b7-38336875780d@redhat.com> (raw)
In-Reply-To: <87k0uiiv0q.fsf@dusky.pond.sub.org>
On 18/11/20 15:45, Markus Armbruster wrote:
> Paolo Bonzini <pbonzini@redhat.com> writes:
>
>> On 18/11/20 14:08, Markus Armbruster wrote:
>>> These look like errors, but aren't; things are working exactly as
>>> intended, and QEMU runs. If we want to be chatty about it, we should
>>> make them info, not error.
>>
>> If there were an info_report, I would have sent a patch already. :)
>
> Commit 97f40301f1 "error: Functions to report warnings and informational
> messages", 2017-07-13 :)
Doh, I just learnt about info_report. It never occurred to me until now
that without a warning or info marker it would be an error. I can see
though why you didn't add "error" automatically for REPORT_TYPE_ERROR,
while leaving REPORT_TYPE_INFO unadorned. Between the
incorrectly-marked errors and probably some "error: error: " it would be
awful.
Paolo
>> In general, these are probably not the only cases where error_report
>> is used as a fancy fprintf(stderr), rather than to report actual
>> errors.
>
> True!
>
next prev parent reply other threads:[~2020-11-18 14:55 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-16 13:10 [PATCH for-6.0 0/6] Add HMP/QMP commands to query accelerator Roman Bolshakov
2020-11-16 13:10 ` [PATCH for-6.0 1/6] qapi: Add query-accel command Roman Bolshakov
2020-11-16 16:20 ` Eric Blake
2020-11-16 18:56 ` Roman Bolshakov
2020-11-16 21:13 ` Eduardo Habkost
2020-11-17 8:51 ` Markus Armbruster
2020-11-18 1:19 ` Roman Bolshakov
2020-11-18 8:36 ` Markus Armbruster
2020-11-18 9:21 ` Paolo Bonzini
2020-11-18 13:08 ` Markus Armbruster
2020-11-18 13:46 ` Paolo Bonzini
2020-11-18 14:45 ` Markus Armbruster
2020-11-18 14:54 ` Paolo Bonzini [this message]
2020-11-18 14:00 ` Roman Bolshakov
2020-11-18 11:28 ` Kevin Wolf
2020-11-18 11:56 ` Daniel P. Berrangé
2020-11-18 13:53 ` Markus Armbruster
2020-11-18 15:45 ` Eduardo Habkost
2020-11-18 15:56 ` Eric Blake
2020-11-18 16:23 ` Eduardo Habkost
2020-11-19 13:17 ` Markus Armbruster
2020-11-30 17:05 ` Philippe Mathieu-Daudé
2020-11-16 13:10 ` [PATCH for-6.0 2/6] qapi: Rename KvmInfo to AccelInfo Roman Bolshakov
2020-11-27 10:40 ` Dr. David Alan Gilbert
2020-11-27 12:08 ` Markus Armbruster
2020-11-16 13:10 ` [PATCH for-6.0 3/6] qapi: Use qmp_query_accel() in qmp_query_kvm() Roman Bolshakov
2020-11-16 13:10 ` [PATCH for-6.0 4/6] softmmu: Remove kvm_available() Roman Bolshakov
2020-11-16 13:10 ` [PATCH for-6.0 5/6] hmp: Add 'info accel' command Roman Bolshakov
2020-11-27 10:39 ` Dr. David Alan Gilbert
2020-11-16 13:10 ` [PATCH for-6.0 6/6] qapi: Deprecate 'query-kvm' Roman Bolshakov
2020-11-27 10:50 ` Daniel P. Berrangé
2020-11-27 11:21 ` Peter Krempa
2020-11-27 11:45 ` Roman Bolshakov
2020-11-27 12:18 ` Peter Krempa
2020-11-27 15:44 ` Markus Armbruster
2020-11-27 16:30 ` Peter Krempa
2020-11-30 9:21 ` Markus Armbruster
2020-11-30 10:09 ` Peter Krempa
2020-11-30 16:03 ` Markus Armbruster
2020-11-30 15:30 ` Eric Blake
2020-11-27 15:53 ` Daniel P. Berrangé
2020-11-27 16:35 ` Peter Krempa
2020-11-19 14:41 ` [PATCH for-6.0 0/6] Add HMP/QMP commands to query accelerator Claudio Fontana
2020-11-19 15:46 ` Roman Bolshakov
2020-11-19 15:54 ` Claudio Fontana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7b4c4d2-3cb6-37a9-45b7-38336875780d@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=ehabkost@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=r.bolshakov@yadro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).