From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75B20C352A3 for ; Mon, 10 Feb 2020 10:27:58 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4213A2080C for ; Mon, 10 Feb 2020 10:27:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="hbxYgJMB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4213A2080C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:59724 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j16IH-0002tL-F4 for qemu-devel@archiver.kernel.org; Mon, 10 Feb 2020 05:27:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51960) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j16Hf-0002Cd-UT for qemu-devel@nongnu.org; Mon, 10 Feb 2020 05:27:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j16Hd-0000Pl-SW for qemu-devel@nongnu.org; Mon, 10 Feb 2020 05:27:18 -0500 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:20504 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j16Hd-0000Oz-Ks for qemu-devel@nongnu.org; Mon, 10 Feb 2020 05:27:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581330436; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:openpgp:openpgp; bh=3I1JFY4Uk5ZJJe8bsZVXIweUHXgN2+/GrubmWyn6ecU=; b=hbxYgJMBripsLTe8ywiodB+5j4TDjK3xIGP0vN/u8p6LKWzF/2vuPI5AMB/6VUrOFDrNqx ty37jYEo6Pfob7lG/CuzhkE+KfytNiaQ8eE96y7H3LtvCMu8PAlGUHDY+qhZwg/UB8kq6m TUqOY2khOiF5aloXIDEgB1Zr1w3gBLw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-358-gvisQ3hQOLWKGW1cKue-RQ-1; Mon, 10 Feb 2020 05:27:15 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DC56213EA; Mon, 10 Feb 2020 10:27:10 +0000 (UTC) Received: from thuth.remote.csb (ovpn-116-219.ams2.redhat.com [10.36.116.219]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7B4828ED0B; Mon, 10 Feb 2020 10:26:54 +0000 (UTC) Subject: Re: Tricore default machine To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org References: <20200207161948.15972-1-philmd@redhat.com> <20200207161948.15972-2-philmd@redhat.com> <9590e020-226d-bc85-e496-95b4f0116f69@redhat.com> From: Thomas Huth Openpgp: preference=signencrypt Message-ID: Date: Mon, 10 Feb 2020 11:26:52 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-MC-Unique: gvisQ3hQOLWKGW1cKue-RQ-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chris Wulff , Sagar Karandikar , "Michael S. Tsirkin" , Anthony Green , Mark Cave-Ayland , Alistair Francis , "Edgar E. Iglesias" , Guan Xuetao , Marek Vasut , Jia Liu , qemu-trivial@nongnu.org, Helge Deller , David Hildenbrand , Magnus Damm , Halil Pasic , Christian Borntraeger , Palmer Dabbelt , Aleksandar Rikalo , Richard Henderson , Artyom Tarasenko , Eduardo Habkost , Richard Henderson , qemu-s390x@nongnu.org, Stafford Horne , David Gibson , qemu-riscv@nongnu.org, Thomas Huth , Bastian Koppelmann , Cornelia Huck , Laurent Vivier , Michael Walle , qemu-ppc@nongnu.org, Aleksandar Markovic , Paolo Bonzini , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 10/02/2020 11.08, Philippe Mathieu-Daud=C3=A9 wrote: > On 2/10/20 10:35 AM, Thomas Huth wrote: >> On 07/02/2020 17.19, Philippe Mathieu-Daud=C3=A9 wrote: >>> The MachineClass is already zeroed on creation. >>> >>> Note: The code setting is_default=3D0 in hw/i386/pc_piix.c is >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 different (related to compat optio= ns). When adding a >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 new versioned machine, we want it = to be the new default, >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 so we have to mark the previous on= e as not default. >>> >>> Signed-off-by: Philippe Mathieu-Daud=C3=A9 >>> --- >>> v3: new patch >>> --- >>> =C2=A0 hw/lm32/lm32_boards.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 1 - >>> =C2=A0 hw/lm32/milkymist.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 1 - >>> =C2=A0 hw/m68k/q800.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 | 1 - >>> =C2=A0 hw/microblaze/petalogix_ml605_mmu.c | 1 - >>> =C2=A0 hw/tricore/tricore_testboard.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 1= - >>> =C2=A0 5 files changed, 5 deletions(-) >> [...] >>> diff --git a/hw/tricore/tricore_testboard.c >>> b/hw/tricore/tricore_testboard.c >>> index 20c9ccb3ce..8ec2b5bddd 100644 >>> --- a/hw/tricore/tricore_testboard.c >>> +++ b/hw/tricore/tricore_testboard.c >>> @@ -105,7 +105,6 @@ static void ttb_machine_init(MachineClass *mc) >>> =C2=A0 { >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 mc->desc =3D "a minimal TriCore board"; >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 mc->init =3D tricoreboard_init; >>> -=C2=A0=C2=A0=C2=A0 mc->is_default =3D 0; >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 mc->default_cpu_type =3D TRICORE_CPU_TYP= E_NAME("tc1796"); >>> =C2=A0 } >> >> I wonder whether we should simply make that machine the default for >> qemu-system-tricore? There is only one machine here, and not having a >> default machine always causes some headaches in the tests... >> (see e.g. tests/qemu-iotests/check for example) >=20 > Or make it generic? If a architecture has a single machine, use it by > default? Sounds like a good idea, too ... we've got a couple of targets that have only one machine. Thomas