Re: [RFC PATCH v7 0/7] vmapple: making it work on the latest macOS host releases

[Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>]

On 2026/03/25 5:48, Mohamed Mediouni wrote:
> v7:
> 
> Support for newer guest OSes.
> 
> Added not mergable patch for private ISA enablement.
> 
> Not grabbing a memory reference and still using flatview_for_each_range
> for this one, which works fine as live migration is disallowed anyway.

I prefer the other solutions suggested earlier. My preference order:
- Use a listener or change flatview_for_each_range() to remove const.
- Casting away const.
- Avoid grabbing memory references (this version)

Regards,
Akihiko Odaki

> 
> v6:
> Rework the patches a bit, with making sure that there's no compiler warnings
> 
> v5:
> Address review comments and rebase.
> 
> v4:
> Rebase and resend without the RFC tag as I didn't get feedback.
> Drop patch 1 (version I posted was incomplete anyways). Last patch isn't worth it too tbh.
> 
> v2->v3:
> Remove the Apple M4 support workaround part for now, to be part of another patchset perhaps
> Address comments
> 
> v1->v2:
> Remove some lines that shouldn't have been present...
> 
> Mohamed Mediouni (7):
>    vmapple: apple-gfx: make it work on the latest macOS release
>    hw/vmapple: aes: convert MAX_LEN to a #define
>    vmapple: declare it as an AArch64-compatible machine
>    Revert "hw/arm: Do not build VMapple machine by default"
>    vmapple: add gicv2m
>    vmapple, gicv2m: add macOS compat quirk
>    hvf: do not merge: enable private ISA
> 
>   accel/hvf/entitlements.plist                |  2 +-
>   configs/devices/aarch64-softmmu/default.mak |  1 -
>   hw/display/apple-gfx-mmio.m                 | 59 ++++++++++++++++-----
>   hw/display/apple-gfx.h                      | 16 ++++++
>   hw/display/apple-gfx.m                      | 41 +++++++++++++-
>   hw/intc/arm_gicv2m.c                        |  5 ++
>   hw/vmapple/aes.c                            |  3 +-
>   hw/vmapple/vmapple.c                        | 27 ++++++++++
>   target/arm/hvf/hvf.c                        |  8 +++
>   9 files changed, 144 insertions(+), 18 deletions(-)
>