From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: "Cédric Le Goater" <clg@kaod.org>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org
Cc: Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>,
Markus Armbruster <armbru@redhat.com>
Subject: Re: [PATCH 0/4] aspeed: Clean up local variable shadowing
Date: Fri, 22 Sep 2023 20:20:56 +0200 [thread overview]
Message-ID: <f7cdbd47-1833-af1a-ae09-363c86c2e74e@linaro.org> (raw)
In-Reply-To: <20230922155924.1172019-1-clg@kaod.org>
On 22/9/23 17:59, Cédric Le Goater wrote:
> Hello,
>
> Here are cleanups for local variable shadowing warnings in aspeed models.
>
> Joel, Andrew,
>
> Could you please double check patch 4 ?
Could Markus' MAKE_IDENTFIER() help there?
>
> Thanks,
>
> C.
>
> Cédric Le Goater (4):
> aspeed/i2c: Clean up local variable shadowing
> aspeed: Clean up local variable shadowing
> aspeed/i3c: Rename variable shadowing a local
> aspeed/timer: Clean up local variable shadowing
>
> hw/arm/aspeed_ast2600.c | 10 +++++-----
> hw/i2c/aspeed_i2c.c | 1 -
> hw/misc/aspeed_i3c.c | 6 +++---
> hw/timer/aspeed_timer.c | 2 +-
> 4 files changed, 9 insertions(+), 10 deletions(-)
>
next prev parent reply other threads:[~2023-09-22 18:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-22 15:59 [PATCH 0/4] aspeed: Clean up local variable shadowing Cédric Le Goater
2023-09-22 15:59 ` [PATCH 1/4] aspeed/i2c: " Cédric Le Goater
2023-09-22 18:22 ` Philippe Mathieu-Daudé
2023-09-27 2:38 ` Joel Stanley
2023-09-22 15:59 ` [PATCH 2/4] aspeed: " Cédric Le Goater
2023-09-22 18:23 ` Philippe Mathieu-Daudé
2023-09-23 6:34 ` Markus Armbruster
2023-09-23 7:10 ` Cédric Le Goater
2023-09-22 15:59 ` [PATCH 3/4] aspeed/i3c: Rename variable shadowing a local Cédric Le Goater
2023-09-22 18:28 ` Philippe Mathieu-Daudé
2023-09-25 6:29 ` Andrew Jeffery
2023-09-22 15:59 ` [PATCH 4/4] aspeed/timer: Clean up local variable shadowing Cédric Le Goater
2023-09-22 18:32 ` Philippe Mathieu-Daudé
2023-09-22 18:20 ` Philippe Mathieu-Daudé [this message]
2023-09-22 19:00 ` [PATCH 0/4] aspeed: " Cédric Le Goater
2023-09-23 7:13 ` Markus Armbruster
2023-09-25 16:28 ` Cédric Le Goater
2023-09-26 6:44 ` Markus Armbruster
2023-09-29 6:46 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7cdbd47-1833-af1a-ae09-363c86c2e74e@linaro.org \
--to=philmd@linaro.org \
--cc=andrew@aj.id.au \
--cc=armbru@redhat.com \
--cc=clg@kaod.org \
--cc=joel@jms.id.au \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).