From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51112) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TZ4Ay-0006V3-HS for qemu-devel@nongnu.org; Thu, 15 Nov 2012 13:28:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TZ4Av-0000vG-FG for qemu-devel@nongnu.org; Thu, 15 Nov 2012 13:28:32 -0500 Received: from ssl.dlhnet.de ([91.198.192.8]:43779 helo=ssl.dlh.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TZ4Av-0000uq-8i for qemu-devel@nongnu.org; Thu, 15 Nov 2012 13:28:29 -0500 Message-ID: In-Reply-To: <50A5101E.1030705@redhat.com> References: <50A50150.8010201@dlhnet.de> <50A5101E.1030705@redhat.com> Date: Thu, 15 Nov 2012 19:28:27 +0100 From: "Peter Lieven" MIME-Version: 1.0 Content-Type: text/plain;charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] iscsi: fix deadlock during login List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: kwolf@redhat.com, Peter Lieven , "qemu-devel@nongnu.org" , ronnie sahlberg Paolo Bonzini wrote: > Il 15/11/2012 15:57, ronnie sahlberg ha scritto: >> I dont know if we should switch to use synchronous code here. >> It is much nicer if all code is async. > > bdrv_open is generally synchronous, so I think Peter's patch is ok. if all is sync wouldn't it be best to have all code in iscsi_open sync then and convert the iscsi_inquiry and iscsi_readcapacity commands also t= o sync? Peter > > Paolo > >> Is it possible to add a timeout instead that would break out if the >> connect/login has not completed within a certain amount of time? > > >