From: John Snow <jsnow@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-block@nongnu.org
Cc: den@openvz.org, qemu-devel@nongnu.org, mreitz@redhat.com
Subject: Re: [PATCH v2 8/8] simplebench/bench_block_job: drop caches before test run
Date: Thu, 4 Mar 2021 20:30:58 -0500 [thread overview]
Message-ID: <f7d24c40-eb01-4df6-52c7-5f48aa30656f@redhat.com> (raw)
In-Reply-To: <20210304101738.20248-9-vsementsov@virtuozzo.com>
On 3/4/21 5:17 AM, Vladimir Sementsov-Ogievskiy wrote:
> It probably may improve reliability of results when testing in cached
> mode.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
> scripts/simplebench/bench_block_job.py | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/scripts/simplebench/bench_block_job.py b/scripts/simplebench/bench_block_job.py
> index 4f03c12169..fa45ad2655 100755
> --- a/scripts/simplebench/bench_block_job.py
> +++ b/scripts/simplebench/bench_block_job.py
> @@ -53,6 +53,8 @@ def bench_block_job(cmd, cmd_args, qemu_args):
> return {'error': 'qemu failed: ' + str(vm.get_log())}
>
> try:
> + subprocess.run('sync; echo 3 > /proc/sys/vm/drop_caches', shell=True,
> + check=True)
> res = vm.qmp(cmd, **cmd_args)
> if res != {'return': {}}:
> vm.shutdown()
>
Worth adding a conditional to allow "hot" or "cold" runs? nah?
next prev parent reply other threads:[~2021-03-05 1:33 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-04 10:17 [PATCH v2 0/8] simplebench improvements Vladimir Sementsov-Ogievskiy
2021-03-04 10:17 ` [PATCH v2 1/8] simplebench: bench_one(): add slow_limit argument Vladimir Sementsov-Ogievskiy
2021-03-05 1:22 ` John Snow
2021-03-05 9:03 ` Vladimir Sementsov-Ogievskiy
2021-03-05 16:25 ` John Snow
2021-03-04 10:17 ` [PATCH v2 2/8] simplebench: bench_one(): support count=1 Vladimir Sementsov-Ogievskiy
2021-03-05 1:23 ` John Snow
2021-03-04 10:17 ` [PATCH v2 3/8] simplebench/bench-backup: add --compressed option Vladimir Sementsov-Ogievskiy
2021-03-04 10:17 ` [PATCH v2 4/8] simplebench/bench-backup: add target-cache argument Vladimir Sementsov-Ogievskiy
2021-03-05 1:50 ` John Snow
2021-03-04 10:17 ` [PATCH v2 5/8] simplebench/bench_block_job: handle error in BLOCK_JOB_COMPLETED Vladimir Sementsov-Ogievskiy
2021-03-05 1:47 ` John Snow
2021-03-04 10:17 ` [PATCH v2 6/8] simplebench/bench-backup: support qcow2 source files Vladimir Sementsov-Ogievskiy
2021-03-05 1:43 ` John Snow
2021-03-04 10:17 ` [PATCH v2 7/8] simplebench/bench-backup: add --count and --no-initial-run Vladimir Sementsov-Ogievskiy
2021-03-05 1:37 ` John Snow
2021-03-05 9:09 ` Vladimir Sementsov-Ogievskiy
2021-03-04 10:17 ` [PATCH v2 8/8] simplebench/bench_block_job: drop caches before test run Vladimir Sementsov-Ogievskiy
2021-03-05 1:30 ` John Snow [this message]
2021-03-05 9:11 ` Vladimir Sementsov-Ogievskiy
2021-03-05 16:30 ` John Snow
2021-03-05 16:50 ` Vladimir Sementsov-Ogievskiy
2021-03-05 16:54 ` John Snow
2021-03-04 10:44 ` [PATCH v2 9/8] MAINTAINERS: update Benchmark util: add git tree Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7d24c40-eb01-4df6-52c7-5f48aa30656f@redhat.com \
--to=jsnow@redhat.com \
--cc=den@openvz.org \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).