From: Paolo Bonzini <pbonzini@redhat.com>
To: "Richard W.M. Jones" <rjones@redhat.com>
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
qemu-devel@nongnu.org, "Stefan Hajnoczi" <stefanha@redhat.com>,
"Frediano Ziglio" <fziglio@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] char: kick main loop after adding a watch
Date: Sat, 1 Apr 2017 12:08:35 +0200 [thread overview]
Message-ID: <f7f6cb59-ec92-a331-8dbb-126c9f23f1eb@redhat.com> (raw)
In-Reply-To: <20170331173101.GL30620@redhat.com>
On 31/03/2017 19:31, Richard W.M. Jones wrote:
> On Fri, Mar 31, 2017 at 06:53:56PM +0200, Paolo Bonzini wrote:
>> glib is expecting QEMU to use g_main_context_acquire around accesses to
>> GMainContext. However QEMU is not doing that, instead it is taking its
>> own mutex. So we should add g_main_context_acquire and
>> g_main_context_release in the two implementations of
>> os_host_main_loop_wait; these should undo the effect of Frediano's
>> glib patch.
>
> Based on this paragraph, I'm testing the attached patch, and it does
> also appear to solve the hanging serial port problem.
Turn out that it may actually be a glib bug. Your patch would enable
Frediano's optimizations so it's worth applying anyway.
https://bugzilla.gnome.org/show_bug.cgi?id=761102
Paolo
next prev parent reply other threads:[~2017-04-01 10:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-31 16:43 [Qemu-devel] [PATCH] char: kick main loop after adding a watch Stefan Hajnoczi
2017-03-31 16:53 ` Paolo Bonzini
2017-03-31 17:31 ` Richard W.M. Jones
2017-03-31 17:31 ` Paolo Bonzini
2017-03-31 17:40 ` Richard W.M. Jones
2017-04-01 10:08 ` Paolo Bonzini [this message]
2017-04-03 13:20 ` Stefan Hajnoczi
2017-03-31 17:09 ` Richard W.M. Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7f6cb59-ec92-a331-8dbb-126c9f23f1eb@redhat.com \
--to=pbonzini@redhat.com \
--cc=fziglio@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rjones@redhat.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).