qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Aaron Conole <aconole@redhat.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: mst@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org,
	jasowang@redhat.com, yuanhan.liu@linux.intel.com
Subject: Re: [Qemu-devel] [RFC v2 0/3] virtio-net: Add support to MTU feature
Date: Fri, 18 Nov 2016 13:15:10 -0500	[thread overview]
Message-ID: <f7tzikwirip.fsf@redhat.com> (raw)
In-Reply-To: <1479419887-10515-1-git-send-email-maxime.coquelin@redhat.com> (Maxime Coquelin's message of "Thu, 17 Nov 2016 22:58:04 +0100")

Maxime Coquelin <maxime.coquelin@redhat.com> writes:

> This series implements Virtio spec update from Aaron Conole which
> defines a way for the host to expose its max MTU to the guest.
>
> Changes since RFC v1:
> ---------------------
>  - Rebased on top of v2.8.0-rc0 (2.7.90)
>  - Write MTU unconditionnaly in netcfg to avoid memory leak (Paolo)
>  - Add host_mtu property to be able to disable the feature from QEMU
>
> Maxime Coquelin (3):
>   vhost-user: Add new protocol feature MTU
>   vhost-net: Add new MTU feature support
>   virtio-net: Add MTU feature support
>
>  hw/net/vhost_net.c             | 11 +++++++++++
>  hw/net/virtio-net.c            | 14 ++++++++++++++
>  hw/virtio/vhost-user.c         | 11 +++++++++++
>  include/hw/virtio/vhost.h      |  1 +
>  include/hw/virtio/virtio-net.h |  1 +
>  include/net/vhost_net.h        |  2 ++
>  6 files changed, 40 insertions(+)

I ran this with a VM, but it seems the offered maximum MTU was of value
0 - is this expected with this version?  How can I change the offered
value?  Sorry, I'm not as familiar with QEMU/libvirt side of the world.

-Aaron

  parent reply	other threads:[~2016-11-18 18:15 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-17 21:58 [Qemu-devel] [RFC v2 0/3] virtio-net: Add support to MTU feature Maxime Coquelin
2016-11-17 21:58 ` [Qemu-devel] [RFC v2 1/3] vhost-user: Add new protocol feature MTU Maxime Coquelin
2016-11-18 14:26   ` Aaron Conole
2016-11-21 12:50     ` Maxime Coquelin
2016-11-17 21:58 ` [Qemu-devel] [RFC v2 2/3] vhost-net: Add new MTU feature support Maxime Coquelin
2016-11-17 22:39   ` Michael S. Tsirkin
2016-11-21 12:51     ` Maxime Coquelin
2016-11-18 18:13   ` Aaron Conole
2016-11-17 21:58 ` [Qemu-devel] [RFC v2 3/3] virtio-net: Add " Maxime Coquelin
2016-11-17 22:38   ` Michael S. Tsirkin
2016-11-21 12:34     ` Maxime Coquelin
2016-11-21 16:48       ` Michael S. Tsirkin
2016-11-22 12:11         ` Maxime Coquelin
2016-11-22 14:18           ` Michael S. Tsirkin
2016-11-22 15:33             ` Maxime Coquelin
2016-11-17 22:34 ` [Qemu-devel] [RFC v2 0/3] virtio-net: Add support to MTU feature Michael S. Tsirkin
2016-11-18  6:42   ` John Fastabend
2016-11-18 18:15 ` Aaron Conole [this message]
2016-11-18 18:52   ` Maxime Coquelin
2016-11-18 19:21     ` Aaron Conole
2016-11-21 16:23       ` Michael S. Tsirkin
2016-11-22  4:07         ` Jason Wang
2016-11-22  7:40           ` Maxime Coquelin
2016-11-22 14:32             ` Aaron Conole
2016-11-22 14:41               ` Michael S. Tsirkin
2016-11-22 17:56                 ` Maxime Coquelin
2016-11-22 20:38                   ` Michael S. Tsirkin
2016-11-23  3:42                     ` Jason Wang
2016-11-23  4:26                       ` Michael S. Tsirkin
2016-11-23 14:02                         ` Aaron Conole
2016-11-23 17:42                           ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f7tzikwirip.fsf@redhat.com \
    --to=aconole@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=yuanhan.liu@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).