From: Thomas Huth <thuth@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: "Mads Ynddal" <mads@ynddal.dk>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH 4/6] tracetool: include SPDX-License-Identifier in generated files
Date: Wed, 6 Aug 2025 11:00:13 +0200 [thread overview]
Message-ID: <f8003773-1e1a-4d9e-8bb5-b99f644c807f@redhat.com> (raw)
In-Reply-To: <20250805200334.629493-5-berrange@redhat.com>
On 05/08/2025 22.03, Daniel P. Berrangé wrote:
> While these files are auto-generated, a later commit will add
> reference output to git, so having SPDX-License-Identifier is
> desirable.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
> scripts/tracetool/format/c.py | 1 +
> scripts/tracetool/format/d.py | 3 ++-
> scripts/tracetool/format/h.py | 1 +
> scripts/tracetool/format/log_stap.py | 1 +
> scripts/tracetool/format/simpletrace_stap.py | 1 +
> scripts/tracetool/format/stap.py | 1 +
> scripts/tracetool/format/ust_events_c.py | 1 +
> scripts/tracetool/format/ust_events_h.py | 1 +
> 8 files changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/tracetool/format/c.py b/scripts/tracetool/format/c.py
> index 7aa51cd41a..e473fb6c6e 100644
> --- a/scripts/tracetool/format/c.py
> +++ b/scripts/tracetool/format/c.py
> @@ -22,6 +22,7 @@ def generate(events, backend, group):
> header = "trace-" + group + ".h"
>
> out('/* This file is autogenerated by tracetool, do not edit. */',
> + '/* SPDX-License-Identifier: GPL-2.0-or-later */',
Would it maybe be possible to inherit the SPDX identifier from the input file?
Anyway, for the time being, this should be fine since we currently don't
have any trace-events file with a non-GPL identifier.
Acked-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2025-08-06 9:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-05 20:03 [PATCH 0/6] tracetool: add test suite to improve reviewability Daniel P. Berrangé
2025-08-05 20:03 ` [PATCH 1/6] checkpatch: cull trailing '*/' in SPDX check Daniel P. Berrangé
2025-08-05 20:03 ` [PATCH 2/6] tracetool: eliminate trailing whitespace in C format Daniel P. Berrangé
2025-08-06 6:42 ` Philippe Mathieu-Daudé
2025-08-05 20:03 ` [PATCH 3/6] tracetool: avoid space after "*" in arg types Daniel P. Berrangé
2025-08-06 6:43 ` Philippe Mathieu-Daudé
2025-08-05 20:03 ` [PATCH 4/6] tracetool: include SPDX-License-Identifier in generated files Daniel P. Berrangé
2025-08-06 6:44 ` Philippe Mathieu-Daudé
2025-08-06 9:00 ` Thomas Huth [this message]
2025-08-05 20:03 ` [PATCH 5/6] tracetool: add test suite for tracetool with reference output Daniel P. Berrangé
2025-08-06 9:08 ` Thomas Huth
2025-08-05 20:03 ` [PATCH 6/6] tracetool: drop the probe "__nocheck__" wrapping Daniel P. Berrangé
2025-08-06 6:46 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8003773-1e1a-4d9e-8bb5-b99f644c807f@redhat.com \
--to=thuth@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=mads@ynddal.dk \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).