From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [PATCH 2/2] target/arm: Relax r13 restriction for ldrex/strex for v8.0
Date: Mon, 18 Nov 2019 14:15:57 +0100 [thread overview]
Message-ID: <f8071794-cb5f-d987-0e7d-11a70ba4d2bc@linaro.org> (raw)
In-Reply-To: <CAFEAcA8FdT8R4_nwUQ1QLBMBST_K0xuHABER3f8kt6JY1vYojw@mail.gmail.com>
On 11/18/19 2:10 PM, Peter Maydell wrote:
>> /* We UNDEF for these UNPREDICTABLE cases. */
>> if (a->rn == 15 || a->rt == 15
>> - || (s->thumb && a->rt == 13)
>> + || (!ENABLE_ARCH_8 && s->thumb && a->rt == 13)
>> || (mop == MO_64
>> && (a->rt2 == 15 || a->rt == a->rt2
>> - || (s->thumb && a->rt2 == 13)))) {
>> + || (!ENABLE_ARCH_8 && s->thumb && a->rt2 == 13)))) {
>> unallocated_encoding(s);
>> return true;
>> }
>
> These cases for r13 are indeed no longer UNPREDICTABLE in
> v8A, but they are still marked as UNPREDICTABLE for v8M...
Ho hum. I knew I should have looked at that doc as well...
r~
next prev parent reply other threads:[~2019-11-18 13:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-17 9:06 [PATCH for-4.2 0/2] target/arm: two fixes for ldrex/strex Richard Henderson
2019-11-17 9:06 ` [PATCH 1/2] target/arm: Do not reject rt == rt2 for strexd Richard Henderson
2019-11-18 13:17 ` Peter Maydell
2019-11-17 9:06 ` [PATCH 2/2] target/arm: Relax r13 restriction for ldrex/strex for v8.0 Richard Henderson
2019-11-18 13:10 ` Peter Maydell
2019-11-18 13:15 ` Richard Henderson [this message]
2019-11-18 17:53 ` Peter Maydell
2019-11-18 20:02 ` Richard Henderson
2019-11-18 21:22 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8071794-cb5f-d987-0e7d-11a70ba4d2bc@linaro.org \
--to=richard.henderson@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).