From: Thomas Huth <thuth@redhat.com>
To: Greg Kurz <groug@kaod.org>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH for-4.0] 9p: remove support for the "handle" backend
Date: Fri, 30 Nov 2018 10:05:07 +0100 [thread overview]
Message-ID: <f814fd63-64a2-a464-7022-2c8f5bac4af6@redhat.com> (raw)
In-Reply-To: <154356772378.66975.13711686652368325931.stgit@bahia.lan>
On 2018-11-30 09:49, Greg Kurz wrote:
> The "handle" fsdev backend was deprecated in QEMU 2.12.0 with:
>
> commit db3b3c7281ca82e2647e072a1f97db111313dd73
> Author: Greg Kurz <groug@kaod.org>
> Date: Mon Jan 8 11:18:23 2018 +0100
>
> 9pfs: deprecate handle backend
>
> This backend raise some concerns:
>
> - doesn't support symlinks
> - fails +100 tests in the PJD POSIX file system test suite [1]
> - requires the QEMU process to run with the CAP_DAC_READ_SEARCH
> capability, which isn't recommended for security reasons
>
> This backend should not be used and wil be removed. The 'local'
> backend is the recommended alternative.
>
> [1] https://www.tuxera.com/community/posix-test-suite/
>
> Signed-off-by: Greg Kurz <groug@kaod.org>
> Reviewed-by: Daniel P. Berrange <berrange@redhat.com>
> Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
>
> It has passed the two release cooling period without any complaint.
>
> Remove it now.
>
> Signed-off-by: Greg Kurz <groug@kaod.org>
> ---
>
> It could have been removed for 3.1.0, but I woke up too late, so moving
> this to 4.0.
>
> ---
> fsdev/qemu-fsdev.c | 3
> hw/9pfs/9p-handle.c | 710 -------------------------------------------------
> hw/9pfs/Makefile.objs | 1
> qemu-deprecated.texi | 8 -
> qemu-options.hx | 8 -
> 5 files changed, 4 insertions(+), 726 deletions(-)
> delete mode 100644 hw/9pfs/9p-handle.c
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2018-11-30 9:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-30 8:49 [Qemu-devel] [PATCH for-4.0] 9p: remove support for the "handle" backend Greg Kurz
2018-11-30 9:05 ` Thomas Huth [this message]
2018-11-30 15:52 ` [Qemu-devel] [PATCH for-3.1?] " Eric Blake
2018-11-30 16:45 ` Greg Kurz
2018-11-30 17:00 ` Peter Maydell
2018-11-30 17:10 ` Greg Kurz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f814fd63-64a2-a464-7022-2c8f5bac4af6@redhat.com \
--to=thuth@redhat.com \
--cc=groug@kaod.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).