From: David Hildenbrand <david@redhat.com>
To: Cornelia Huck <cohuck@redhat.com>
Cc: qemu-s390x@nongnu.org, qemu-devel@nongnu.org,
Eduardo Habkost <ehabkost@redhat.com>,
Christian Borntraeger <borntraeger@de.ibm.com>
Subject: Re: [Qemu-devel] [PATCH v1] numa: s390x has no NUMA
Date: Mon, 26 Feb 2018 11:28:26 +0100 [thread overview]
Message-ID: <f8266a54-7b02-020b-b742-f7b81ed987ab@redhat.com> (raw)
In-Reply-To: <20180226111953.1e9bc50c.cohuck@redhat.com>
On 26.02.2018 11:19, Cornelia Huck wrote:
> On Fri, 23 Feb 2018 18:36:57 +0100
> David Hildenbrand <david@redhat.com> wrote:
>
>> Right now it is possible to crash QEMU for s390x by providing e.g.
>> -numa node,nodeid=0,cpus=0-1
>>
>> Problem is, that numa.c uses mc->cpu_index_to_instance_props as an
>> indicator whether NUMA is supported by a machine type. We don't
>> implement NUMA on s390x (and that concept also doesn't really exist).
>> We need mc->cpu_index_to_instance_props for query-cpus.
>
> Is existence of cpu_index_to_instance_probs the correct indicator for
> numa, then?
>
> OTOH, your patch is straightforward...
Maybe it is get_default_cpu_node_id as Christian discovered?
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2018-02-26 10:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-23 17:36 [Qemu-devel] [PATCH v1] numa: s390x has no NUMA David Hildenbrand
2018-02-26 8:49 ` [Qemu-devel] [qemu-s390x] " Claudio Imbrenda
2018-02-26 9:20 ` [Qemu-devel] " Christian Borntraeger
2018-02-26 9:25 ` David Hildenbrand
2018-02-26 10:19 ` Cornelia Huck
2018-02-26 10:28 ` David Hildenbrand [this message]
2018-02-26 10:35 ` Cornelia Huck
2018-02-26 11:07 ` Christian Borntraeger
2018-02-26 11:12 ` David Hildenbrand
2018-02-26 11:23 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8266a54-7b02-020b-b742-f7b81ed987ab@redhat.com \
--to=david@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=ehabkost@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).