Re: [Qemu-devel] [PATCH v3 02/10] block: Add blklogwrites

[Eric Blake <eblake@redhat.com>]

On 06/07/2018 10:38 AM, Ari Sundholm wrote:
> From: Aapo Vienamo <aapo@tuxera.com>
> 
> Implements a block device write logging system, similar to Linux kernel
> device mapper dm-log-writes. The write operations that are performed
> on a block device are logged to a file or another block device. The
> write log format is identical to the dm-log-writes format. Currently,
> log markers are not supported.
> 
> This functionality can be used for crash consistency and fs consistency
> testing. By implementing it in qemu, tests utilizing write logs can be
> be used to test non-Linux drivers and older kernels.
> 
> The implementation is based on the blkverify and blkdebug block drivers.
> 
> Signed-off-by: Aapo Vienamo <aapo@tuxera.com>
> Signed-off-by: Ari Sundholm <ari@tuxera.com>
> ---
>   MAINTAINERS          |   6 +
>   block/Makefile.objs  |   1 +
>   block/blklogwrites.c | 383 +++++++++++++++++++++++++++++++++++++++++++++++++++
>   qapi/block-core.json |  29 +++-

I commented on v2 before seeing v3; but the same issues are still 
present in block-core.json (since our mails crossed).

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org