* [PATCH] hw/virtio/virtio-iommu-pci.c: Fix typo in error message
@ 2020-06-25 10:08 Peter Maydell
2020-06-25 10:18 ` Philippe Mathieu-Daudé
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Peter Maydell @ 2020-06-25 10:08 UTC (permalink / raw)
To: qemu-devel; +Cc: Eric Auger, Markus Armbruster, Michael S. Tsirkin
Fix a typo in an error message in virtio_iommu_pci_realize():
"Check you machine" should be "Check your machine".
Reported-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
hw/virtio/virtio-iommu-pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/virtio/virtio-iommu-pci.c b/hw/virtio/virtio-iommu-pci.c
index 632533abaf7..32e3215d1df 100644
--- a/hw/virtio/virtio-iommu-pci.c
+++ b/hw/virtio/virtio-iommu-pci.c
@@ -48,7 +48,7 @@ static void virtio_iommu_pci_realize(VirtIOPCIProxy *vpci_dev, Error **errp)
"%s machine fails to create iommu-map device tree bindings",
mc->name);
error_append_hint(errp,
- "Check you machine implements a hotplug handler "
+ "Check your machine implements a hotplug handler "
"for the virtio-iommu-pci device\n");
error_append_hint(errp, "Check the guest is booted without FW or with "
"-no-acpi\n");
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] hw/virtio/virtio-iommu-pci.c: Fix typo in error message
2020-06-25 10:08 [PATCH] hw/virtio/virtio-iommu-pci.c: Fix typo in error message Peter Maydell
@ 2020-06-25 10:18 ` Philippe Mathieu-Daudé
2020-06-26 7:37 ` Auger Eric
2020-07-01 7:09 ` Markus Armbruster
2 siblings, 0 replies; 5+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-06-25 10:18 UTC (permalink / raw)
To: Peter Maydell, qemu-devel
Cc: Eric Auger, Markus Armbruster, Michael S. Tsirkin
On 6/25/20 12:08 PM, Peter Maydell wrote:
> Fix a typo in an error message in virtio_iommu_pci_realize():
> "Check you machine" should be "Check your machine".
>
> Reported-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> hw/virtio/virtio-iommu-pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/virtio/virtio-iommu-pci.c b/hw/virtio/virtio-iommu-pci.c
> index 632533abaf7..32e3215d1df 100644
> --- a/hw/virtio/virtio-iommu-pci.c
> +++ b/hw/virtio/virtio-iommu-pci.c
> @@ -48,7 +48,7 @@ static void virtio_iommu_pci_realize(VirtIOPCIProxy *vpci_dev, Error **errp)
> "%s machine fails to create iommu-map device tree bindings",
> mc->name);
> error_append_hint(errp,
> - "Check you machine implements a hotplug handler "
> + "Check your machine implements a hotplug handler "
> "for the virtio-iommu-pci device\n");
> error_append_hint(errp, "Check the guest is booted without FW or with "
> "-no-acpi\n");
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] hw/virtio/virtio-iommu-pci.c: Fix typo in error message
2020-06-25 10:08 [PATCH] hw/virtio/virtio-iommu-pci.c: Fix typo in error message Peter Maydell
2020-06-25 10:18 ` Philippe Mathieu-Daudé
@ 2020-06-26 7:37 ` Auger Eric
2020-07-01 7:09 ` Markus Armbruster
2 siblings, 0 replies; 5+ messages in thread
From: Auger Eric @ 2020-06-26 7:37 UTC (permalink / raw)
To: Peter Maydell, qemu-devel; +Cc: Markus Armbruster, Michael S. Tsirkin
Hi Peter,
On 6/25/20 12:08 PM, Peter Maydell wrote:
> Fix a typo in an error message in virtio_iommu_pci_realize():
> "Check you machine" should be "Check your machine".
>
> Reported-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Thanks
Eric
> ---
> hw/virtio/virtio-iommu-pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/virtio/virtio-iommu-pci.c b/hw/virtio/virtio-iommu-pci.c
> index 632533abaf7..32e3215d1df 100644
> --- a/hw/virtio/virtio-iommu-pci.c
> +++ b/hw/virtio/virtio-iommu-pci.c
> @@ -48,7 +48,7 @@ static void virtio_iommu_pci_realize(VirtIOPCIProxy *vpci_dev, Error **errp)
> "%s machine fails to create iommu-map device tree bindings",
> mc->name);
> error_append_hint(errp,
> - "Check you machine implements a hotplug handler "
> + "Check your machine implements a hotplug handler "
> "for the virtio-iommu-pci device\n");
> error_append_hint(errp, "Check the guest is booted without FW or with "
> "-no-acpi\n");
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] hw/virtio/virtio-iommu-pci.c: Fix typo in error message
2020-06-25 10:08 [PATCH] hw/virtio/virtio-iommu-pci.c: Fix typo in error message Peter Maydell
2020-06-25 10:18 ` Philippe Mathieu-Daudé
2020-06-26 7:37 ` Auger Eric
@ 2020-07-01 7:09 ` Markus Armbruster
2 siblings, 0 replies; 5+ messages in thread
From: Markus Armbruster @ 2020-07-01 7:09 UTC (permalink / raw)
To: Peter Maydell
Cc: Eric Auger, Michael S. Tsirkin, qemu-devel, Markus Armbruster
Peter Maydell <peter.maydell@linaro.org> writes:
> Fix a typo in an error message in virtio_iommu_pci_realize():
> "Check you machine" should be "Check your machine".
>
> Reported-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> hw/virtio/virtio-iommu-pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/virtio/virtio-iommu-pci.c b/hw/virtio/virtio-iommu-pci.c
> index 632533abaf7..32e3215d1df 100644
> --- a/hw/virtio/virtio-iommu-pci.c
> +++ b/hw/virtio/virtio-iommu-pci.c
> @@ -48,7 +48,7 @@ static void virtio_iommu_pci_realize(VirtIOPCIProxy *vpci_dev, Error **errp)
> "%s machine fails to create iommu-map device tree bindings",
> mc->name);
> error_append_hint(errp,
> - "Check you machine implements a hotplug handler "
> + "Check your machine implements a hotplug handler "
> "for the virtio-iommu-pci device\n");
> error_append_hint(errp, "Check the guest is booted without FW or with "
> "-no-acpi\n");
Since I have a bunch of error reporting patches to merge, I'm taking the
liberty to queue this along with them. Hope that's okay. Thanks!
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] hw/virtio/virtio-iommu-pci.c: Fix typo in error message
2020-10-12 15:33 [PATCH 00/10] target/arm: Various v8.1M minor features Peter Maydell
@ 2020-10-12 15:33 ` Peter Maydell
0 siblings, 0 replies; 5+ messages in thread
From: Peter Maydell @ 2020-10-12 15:33 UTC (permalink / raw)
To: qemu-arm, qemu-devel; +Cc: Richard Henderson
Fix a typo in an error message in virtio_iommu_pci_realize():
"Check you machine" should be "Check your machine".
Reported-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
hw/virtio/virtio-iommu-pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/virtio/virtio-iommu-pci.c b/hw/virtio/virtio-iommu-pci.c
index 632533abaf7..32e3215d1df 100644
--- a/hw/virtio/virtio-iommu-pci.c
+++ b/hw/virtio/virtio-iommu-pci.c
@@ -48,7 +48,7 @@ static void virtio_iommu_pci_realize(VirtIOPCIProxy *vpci_dev, Error **errp)
"%s machine fails to create iommu-map device tree bindings",
mc->name);
error_append_hint(errp,
- "Check you machine implements a hotplug handler "
+ "Check your machine implements a hotplug handler "
"for the virtio-iommu-pci device\n");
error_append_hint(errp, "Check the guest is booted without FW or with "
"-no-acpi\n");
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-10-12 15:51 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-06-25 10:08 [PATCH] hw/virtio/virtio-iommu-pci.c: Fix typo in error message Peter Maydell
2020-06-25 10:18 ` Philippe Mathieu-Daudé
2020-06-26 7:37 ` Auger Eric
2020-07-01 7:09 ` Markus Armbruster
-- strict thread matches above, loose matches on Subject: below --
2020-10-12 15:33 [PATCH 00/10] target/arm: Various v8.1M minor features Peter Maydell
2020-10-12 15:33 ` [PATCH] hw/virtio/virtio-iommu-pci.c: Fix typo in error message Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).