From: "Kasireddy, Vivek" <vivek.kasireddy@intel.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: RE: [PATCH v2 07/12] virtio-gpu: Add virtio_gpu_resource_create_blob
Date: Fri, 30 Apr 2021 06:59:11 +0000 [thread overview]
Message-ID: <f849fc8706bc49e5be67b6f240e5e7bc@intel.com> (raw)
In-Reply-To: <20210428091643.rkqmgwptjbhyvpim@sirius.home.kraxel.org>
Hi Gerd,
> > res->remapsz = QEMU_ALIGN_UP(res->remapsz,
> > qemu_real_host_page_size);
> >
> > res->remapped = mmap(NULL, res->remapsz, PROT_READ, @@ -152,7
> > +155,9 @@ void virtio_gpu_init_udmabuf(struct virtio_gpu_simple_resource *res)
> > pdata = res->remapped;
> > }
> >
> > - (void) pdata;
> > + if (pdata) {
> > + res->blob = pdata;
> > + }
> > }
>
> That is confusing. Patch #2 introduces code which is removed here (probably leftovers
> from udmabuf prototype which didn't use blob resources). I think it would be useful to
> merge patch #2 with this one.
[Kasireddy, Vivek] Ok, will do.
>
> Also we might cleanup things a bit. Do we need separate remapsz + blob_size fields in the
> first place? Probably not ...
[Kasireddy, Vivek] Right, we don't. I was also going to slightly change the names of some
of the new functions in v3 to keep them consistent with the rest of the code. Do you have
any additional feedback for the other patches that I can include in v3?
>
> take care,
> Gerd
>
> PS: Can you explicitly cc me on the next version of the patch series?
> Some patches (this one for example) are on the list only and not in
> my inbox. Thanks.
[Kasireddy, Vivek] Sure. I was hoping that including the Based-on-patch-by
tag would do just that but looks like it doesn't.
Thanks,
Vivek
next prev parent reply other threads:[~2021-04-30 7:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-20 6:53 [PATCH v2 00/12] virtio-gpu: Add support for Blob resources feature Vivek Kasireddy
2021-04-20 6:53 ` [PATCH v2 01/12] ui: Get the fd associated with udmabuf driver Vivek Kasireddy
2021-04-20 6:53 ` [PATCH v2 02/12] virtio-gpu: Add udmabuf helpers Vivek Kasireddy
2021-04-21 10:57 ` Gerd Hoffmann
2021-04-20 6:53 ` [PATCH v2 03/12] virtio-gpu: Add virtio_gpu_find_check_resource Vivek Kasireddy
2021-04-20 6:53 ` [PATCH v2 04/12] virtio-gpu: Refactor virtio_gpu_set_scanout Vivek Kasireddy
2021-04-20 6:53 ` [PATCH v2 05/12] virtio-gpu: Refactor virtio_gpu_create_mapping_iov Vivek Kasireddy
2021-04-20 6:53 ` [PATCH v2 06/12] virtio-gpu: Add initial definitions for blob resources Vivek Kasireddy
2021-04-20 6:53 ` [PATCH v2 07/12] virtio-gpu: Add virtio_gpu_resource_create_blob Vivek Kasireddy
2021-04-28 9:16 ` Gerd Hoffmann
2021-04-30 6:59 ` Kasireddy, Vivek [this message]
2021-04-30 11:38 ` Gerd Hoffmann
2021-04-20 6:53 ` [PATCH v2 08/12] ui/pixman: Add qemu_pixman_to_drm_format() Vivek Kasireddy
2021-04-20 6:53 ` [PATCH v2 09/12] virtio-gpu: Add helpers to create and destroy dmabuf objects Vivek Kasireddy
2021-04-20 6:53 ` [PATCH v2 10/12] virtio-gpu: Factor out update scanout Vivek Kasireddy
2021-04-20 6:53 ` [PATCH v2 11/12] virtio-gpu: Add virtio_gpu_set_scanout_blob Vivek Kasireddy
2021-04-20 6:53 ` [PATCH v2 12/12] virtio-gpu: Update cursor data using blob Vivek Kasireddy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f849fc8706bc49e5be67b6f240e5e7bc@intel.com \
--to=vivek.kasireddy@intel.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).