From: Paolo Bonzini <pbonzini@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH v2] chardev: add nodelay option
Date: Wed, 3 Mar 2021 14:31:09 +0100 [thread overview]
Message-ID: <f8514ec5-76e0-e602-4dee-8a28d29a0aa3@redhat.com> (raw)
In-Reply-To: <87mtvkjrpe.fsf@dusky.pond.sub.org>
On 03/03/21 14:24, Markus Armbruster wrote:
> $ qemu-system-x86_64 -chardev socket,id=chr0,path=sock,nodelay=on
> qemu-system-x86_64: -chardev socket,id=chr0,path=sock,nodelay=on: Invalid parameter 'nodelay'
>
> You forgot to update qemu_chardev_opts:
>
> diff --git a/chardev/char.c b/chardev/char.c
> index 288efebd12..e6128c046f 100644
> --- a/chardev/char.c
> +++ b/chardev/char.c
> @@ -864,6 +864,9 @@ QemuOptsList qemu_chardev_opts = {
> },{
> .name = "server",
> .type = QEMU_OPT_BOOL,
> + },{
> + .name = "nodelay",
> + .type = QEMU_OPT_BOOL,
> },{
> .name = "delay",
> .type = QEMU_OPT_BOOL,
Well, I forgot to commit it. But the outcome is the same. Thanks. :(
Paolo
next prev parent reply other threads:[~2021-03-03 13:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-03 12:32 [PATCH v2] chardev: add nodelay option Paolo Bonzini
2021-03-03 13:24 ` Markus Armbruster
2021-03-03 13:31 ` Paolo Bonzini [this message]
2021-03-03 13:51 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8514ec5-76e0-e602-4dee-8a28d29a0aa3@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).