From: Alexey Kardashevskiy <aik@ozlabs.ru>
To: qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org, David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH qemu v3] spapr: Kill SLOF
Date: Wed, 8 Jan 2020 15:27:30 +1100 [thread overview]
Message-ID: <f8586578-a3fa-eb05-3105-51f39a03cfb5@ozlabs.ru> (raw)
In-Reply-To: <20200108023028.96487-1-aik@ozlabs.ru>
On 08/01/2020 13:30, Alexey Kardashevskiy wrote:
> +
> +uint32_t spapr_of_client_open(SpaprMachineState *spapr, uint32_t phandle)
Ooops, this should have been an address of a path, not a phandle.
> +{
> + g_assert(spapr->of_instance_last != 0xFFFFFFFF);
> + ++spapr->of_instance_last;
> + g_hash_table_insert(spapr->of_instances,
> + GINT_TO_POINTER(spapr->of_instance_last),
> + GINT_TO_POINTER(phandle));
> +
> + return spapr->of_instance_last;
> +}
--
Alexey
prev parent reply other threads:[~2020-01-08 4:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-08 2:30 [PATCH qemu v3] spapr: Kill SLOF Alexey Kardashevskiy
2020-01-08 4:27 ` Alexey Kardashevskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8586578-a3fa-eb05-3105-51f39a03cfb5@ozlabs.ru \
--to=aik@ozlabs.ru \
--cc=david@gibson.dropbear.id.au \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).