From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MOZ6e-0006k9-0x for qemu-devel@nongnu.org; Wed, 08 Jul 2009 11:30:48 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MOZ6Z-0006ho-7g for qemu-devel@nongnu.org; Wed, 08 Jul 2009 11:30:47 -0400 Received: from [199.232.76.173] (port=57479 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MOZ6Z-0006hi-0a for qemu-devel@nongnu.org; Wed, 08 Jul 2009 11:30:43 -0400 Received: from mail-fx0-f211.google.com ([209.85.220.211]:33453) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MOZ6Y-0006fs-Lc for qemu-devel@nongnu.org; Wed, 08 Jul 2009 11:30:42 -0400 Received: by fxm7 with SMTP id 7so4999087fxm.34 for ; Wed, 08 Jul 2009 08:30:41 -0700 (PDT) MIME-Version: 1.0 Sender: paolo.bonzini@gmail.com In-Reply-To: <20090708152833.GA12508%yamahata@valinux.co.jp> References: <1246605098-24411-1-git-send-email-yamahata@valinux.co.jp> <1246605098-24411-10-git-send-email-yamahata@valinux.co.jp> <4A544E5F.2050700@gnu.org> <20090708152833.GA12508%yamahata@valinux.co.jp> From: Paolo Bonzini Date: Wed, 8 Jul 2009 17:30:19 +0200 Message-ID: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 09/17] pc.c: remove a global variable, RTCState *rtc_state. List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Isaku Yamahata Cc: qemu-devel@nongnu.org > The case you pointed out is handled in pc.h. > Or are you suggesting that they should be defined in pc.c even when > TARGET_I386 isn't defined? Yes, sorry for not being precise. I also think that cmos_set_s3_resume_init should work even if TARGET_I386 isn't defined. Only cmos_set_s3_resume should be a nop. Thanks, Paolo